-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Remove all patches from pyavtiz, rollback to d502356. #8423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
I understand motive made by Patrick and I understand that nobody wants that things breaks down. Proper - happiness for all - solution would be having two configs, full and minimal. This would stop this conflict which we have to avoid. But this brings some work. But at least we can try to employ AI for this. I was doing some experiments armbian/armbian.github.io#52 just need to figure out how to make this action workable for everyone, perhaps even from CLI. Another option is to add DEFCONFIG propery to the kernel family and a switch MINIMAL_KERNEL_CONFIG that will use upstream defconfig for particular family. However this is not the best solution as many important things will still be missing out. I am on for AI assisted config adjustment having our full config as input and telling AI "strip out dvb tuners, strip out ...". This will then generate minimal config and auto-propose changes with a PR? But the problem going back from a cleaned config at the present state - i made clean (and as minimal as possible) cloud config for uefi targets, but something was missing and current way ended up in a mess / breaks all the work that was done / #8377 and resulting config is dirty yet again (but problem was fixed). Then there is another problem related to kernel configs. Since moving from full to defconfigs, kernel security analysis stopped working. Not that this is something critical, but it was a nice add-on. https://github.com/armbian/build/actions/workflows/pr-kernel-security-analysis.yml My 2c. |
|
remove this PR. |
Let's calm down. This repository = development stage - not production. We (and all kernel community) breaks (and fix) things every day. This doesn't solve the conflict. I am sure you are not the only one with those problems. At this stage we can further compare configs but if results are not satisfactory, we still can revert. |
Description
Remove all patches from pyavtiz, rollback to d502356. PPS and owserver works well
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
GitHub issue reference:
Jira reference number [AR-9999]
Documentation summary for feature / change
Please delete this section if entry to main documentation is not needed.
If documentation entry is predicted, please provide key elements for further implementation into main documentation and set label to "Needs Documentation". You are welcome to open a PR to documentation or you can leave following information for technical writer:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
Checklist:
Please delete options that are not relevant.