-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Update U-Boot to 2025.10 and refactor Youyeetoo R1 DTS (ES8323 audio + NPU) #8810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates configuration for the youyeetoo-r1-v3 board and associated kernel driver support. Changes include: updating the board's audio device naming from ES8388 to ES8323 in naming rules, bumping U-Boot version references from v2025.04 to v2025.10, adding a new hook function to allow U-Boot to auto-detect DTB names when using mainline U-Boot, adjusting boot target ordering in common Rockchip configuration, and enabling the CONFIG_SND_SOC_ES8323 kernel audio driver. Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes The changes consist primarily of version updates (v2025.04 to v2025.10) and configuration adjustments across two files. While the new hook function for DTB auto-detection and boot target reordering introduce minor logic considerations, the overall pattern is straightforward and relatively homogeneous. The kernel config change is a single-line addition. Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
config/kernel/linux-rockchip64-edge.config (1)
2194-2194: Verify the built-in driver choice for ES8323.The ES8323 codec is enabled as built-in (
=y), while the neighboring ES8316 (line 2193) and ES8326 (line 2195) codecs are configured as modules (=m). Building it in is reasonable for board-specific hardware, but consider whether a module would provide better flexibility for users who may not need this codec.If a module is preferred, apply this change:
-CONFIG_SND_SOC_ES8323=y +CONFIG_SND_SOC_ES8323=mconfig/boards/youyeetoo-r1-v3.csc (1)
56-61: Verify U-Boot auto-detection works and consider branch-specific logic.This new function unsets
BOOT_FDT_FILEto allow U-Boot to auto-detect the DTB. A few considerations:
Auto-detection verification: The comment states "U-boot 2025.04+ can detect and set fdtfile automatically on youyeetoo r1 v3", but this needs confirmation with v2025.10 on actual hardware. Boot failure will occur if auto-detection fails.
Vendor kernel builds: This function runs unconditionally for all kernel branches (vendor, current, edge). If vendor builds use different U-Boot (e.g., not mainline), they might need the explicit
BOOT_FDT_FILEsetting. Consider adding a branch check:if [[ "${BRANCH}" != "vendor" ]]; then unset BOOT_FDT_FILE fiFunction naming: The function name includes "v3" but the comment suggests it works for "both variants". Consider clarifying which variants are supported.
The verification mentioned in line 41-42 comment will help confirm point 1 above. For point 2, please confirm whether vendor builds are intended to use this configuration or if there's a separate board config file for vendor/LTS builds as suggested by the comment on line 58.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (3)
patch/kernel/archive/rockchip64-6.18/dt/rk3588s-youyeetoo-r1.dtsis excluded by!patch/**patch/u-boot/v2025.10/board_youyeetoo-r1-v3/youyeetoo-r1-v3-add-support.patchis excluded by!patch/**patch/u-boot/v2025.10/board_youyeetoo-r1-v3/youyeetoo-r1-v3-upstream-dts.patchis excluded by!patch/**
📒 Files selected for processing (2)
config/boards/youyeetoo-r1-v3.csc(3 hunks)config/kernel/linux-rockchip64-edge.config(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-10-14T05:08:11.785Z
Learnt from: EvilOlaf
PR: armbian/build#8754
File: config/boards/bestv-r3300-l.csc:14-16
Timestamp: 2025-10-14T05:08:11.785Z
Learning: In the Armbian build system, BOOTBRANCH_BOARD is a valid framework variable used as a fallback when BOOTBRANCH is unset. The framework checks BOOTBRANCH_BOARD before applying the default bootloader branch value (see config/sources/common.conf). Board configuration files can use BOOTBRANCH_BOARD to specify the bootloader branch.
Applied to files:
config/boards/youyeetoo-r1-v3.csc
📚 Learning: 2025-06-04T23:45:38.860Z
Learnt from: djurny
PR: armbian/build#8272
File: config/bootscripts/boot-mvebu.cmd:182-186
Timestamp: 2025-06-04T23:45:38.860Z
Learning: In config/bootscripts/boot-mvebu.cmd, the `fdtfile` variable is mandatory for booting and is pre-set by U-Boot, but can be overridden via armbianEnv.txt. If `fdtfile` is empty, the subsequent device tree file search logic will eventually fail and trigger the critical error "Cannot find DT!" with proper error handling.
Applied to files:
config/boards/youyeetoo-r1-v3.csc
🔇 Additional comments (2)
config/boards/youyeetoo-r1-v3.csc (2)
20-20: LGTM - Audio device naming correction looks good.The change from
platform-es8388-soundtoplatform-es8323-soundcorrectly reflects the actual hardware codec and aligns with the kernel driver being enabled inlinux-rockchip64-edge.config.
41-42: U-Boot v2025.10 version bump verified.The U-Boot version has been successfully updated from v2025.04 to v2025.10:
- The v2025.10 tag exists in the U-Boot repository
- Patches for v2025.10 are available, including board-specific patches
BOOTBRANCH and BOOTPATCHDIR changes are consistent with this version.
|
✅ This PR has been reviewed and approved — all set for merge! |
Description
This PR updates U-Boot to version 2025.10 and refactors the Youyeetoo R1 device tree with audio and NPU support improvements.
Changes include:
CONFIG_SND_SOC_ES8323=yin linux-rockchip64-edge.config for proper audio codec driver supportHow Has This Been Tested?
Checklist: