Skip to content

Conversation

@awsiv
Copy link
Contributor

@awsiv awsiv commented Mar 15, 2020

Allow additional attributes:

applicationDescription (Default: "")
platformHealthOnly (Default: false)
platformHealthOnlyShowOverride (Default: false)

@paleg
Copy link

paleg commented May 16, 2020

Is this going to be merged? We really need to be able to configure platformHealthOnly.

Note: it does not support attributes update, they can be set only during initial application creation.

@awsiv
Copy link
Contributor Author

awsiv commented May 29, 2020

@paleg I posted this earlier in spinnaker slack

Spinnaker healthchecks demystified

Spinnaker checks for following health status

  • Platform health (AWS/ECS health status - needs to be enabled in the app)

  • LoadBalancer/targetgroup health status (enabled by default if TG is attached)
     
    Internally, Spinnaker(Orca) works with healthchecks depending on the value of interestingHealthProviderNames

  • "interestingHealthProviderNames": null  (listens to HC from discovery + platform or LB/TG depending on what is configured)

  • "interestingHealthProviderNames": []      (skips HC completely)

  • "interestingHealthProviderNames" : ["ecs", "LoadBalancer", "TargetGroup"]  (Listens to status from the list, think any returning true results to true, ie. OR'ed but need to confirm)
    When a container healthcheck is configured, this is reported by the ECS platform

For ec2 it’s “Amazon”

So if you update your pipeline json with one of the above, you should get the desired behavior without changing the option in application.

Not sure about other providers though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants