-
Notifications
You must be signed in to change notification settings - Fork 5
WIP inline slideshow #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
WIP inline slideshow #796
Conversation
Automated PR SummaryThis PR introduces a new feature for handling slideshow components on landing pages, specifically targeting a new type called "Research Center." The changes include updates across multiple files that add functionality and styling for the slideshow, integrate it within the landing page flow, and allow for its configuration in the backend. Additionally, the PR modifies existing CSS for better alignment with the new slideshow setup and extends the backend Twill CMS capabilities to manage these new types of content more effectively. Potential bugs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are issues I'm seeing with both attempted implementations:
- This implementation is misaligned and improperly styled until you scroll to the final slide manually, then the whole component "rolls up" into a slideshow. Clicking on the slideshow position pips navigates to the correct slide the first or second time, but then stops working. The snapping to each slide in the slideshow while manually scrolling does work, tho!
- This implementation looks correct, but also clicking on the position pips only works the first time or so. Snapping to each slide in the slideshow on scroll does not work.
I believe the issue with clicking on the position pips is related to the focusDisplayHandler
core behavior, because I see data-focus-method=mouse
appear on the <a>
when trying to navigate.
@@ -0,0 +1,246 @@ | |||
.m-slideshow.i-1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the "Real Simple Slider" implementation: https://codepen.io/chriscoyier/pen/XwbNwX
} | ||
} | ||
|
||
.m-slideshow.i-2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the "CSS-only Carousel Slider" implementation: https://codepen.io/Schepp/pen/WNbQByE
name='_implementation' | ||
label='Implementation' | ||
:required='true' | ||
:options="['1', '2']" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just temporary
|
||
<div class="m-slideshow__carousel"> | ||
@foreach ($slides as $slide) | ||
<div id="i-{{ $_implementation }}-slide-{{ $loop->iteration }}" class="m-slideshow__slide"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to figure out a good solution for the slide ids. Since there may be multiple slideshows on one page, each id has to be unique to both the slide and the block.
f283248
to
7f1eddc
Compare
|
No description provided.