Skip to content

Commit

Permalink
fix: docker build (#143)
Browse files Browse the repository at this point in the history
  • Loading branch information
arthurhenrique committed Jan 6, 2024
1 parent d220d5f commit 87e1446
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion cookiecutter.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"machine_learn_model_name": "model.pkl",
"input_example_path": "./ml/model/examples/example.json",
"full_name": "Your name",
"email": "Your address email ([email protected])",
"email": "you <[email protected]>",
"release_date": "{% now 'local' %}",
"version": "0.1.0",
"_copy_without_render": [
Expand Down
2 changes: 1 addition & 1 deletion {{cookiecutter.project_slug}}/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ WORKDIR /app
COPY poetry.lock pyproject.toml ./
RUN pip install --upgrade pip && \
pip install poetry && \
poetry config virtualenvs.create false
poetry config virtualenvs.create false

ARG DEV=false
RUN if [ "$DEV" = "true" ] ; then poetry install --with dev ; else poetry install --only main ; fi
Expand Down
6 changes: 4 additions & 2 deletions {{cookiecutter.project_slug}}/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ Application parts are:
└── tests - pytest

## GCP

Deploying inference service to Cloud Run

### Authenticate
Expand All @@ -112,6 +113,7 @@ Deploying inference service to Cloud Run
2. Delete Docker image in GCR

## AWS

Deploying inference service to AWS Lambda

### Authenticate
Expand All @@ -123,9 +125,9 @@ Deploying inference service to AWS Lambda

1. Run `sam build`
2. Run `sam deploy --guiChange this portion for other types of models

## Add the correct type hinting when completed

`aws cloudformation delete-stack --stack-name <STACK_NAME_ON_CREATION>`


Made by https://github.com/arthurhenrique/cookiecutter-fastapi/graphs/contributors with ❤️
Made by <https://github.com/arthurhenrique/cookiecutter-fastapi/graphs/contributors> with ❤️
2 changes: 1 addition & 1 deletion {{cookiecutter.project_slug}}/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: "3"

services:
app:
build:
build:
context: .
args:
DEV: "true"
Expand Down
4 changes: 2 additions & 2 deletions {{cookiecutter.project_slug}}/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "{{cookiecutter.project_name}}"
version = "0.1.0"
description = "{{cookiecutter.project_short_description}}"
authors = ["{{cookiecutter.full_name}} ({{cookiecutter.email}})"]
authors = ["{{cookiecutter.full_name}} <{{cookiecutter.email}}>"]

[tool.poetry.dependencies]
python = "^3.9"
Expand Down Expand Up @@ -44,4 +44,4 @@ exclude = '''
|Dockerfile
|Jenkinfile
)/
'''
'''

0 comments on commit 87e1446

Please sign in to comment.