Skip to content

Minor refactor around config #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Minor refactor around config #1366

merged 2 commits into from
Jul 3, 2025

Conversation

Tang8330
Copy link
Contributor

@Tang8330 Tang8330 commented Jul 3, 2025 •
edited
Loading

Using cmp.Or and inlining more to be consistent with the rest of our codebase.

@Tang8330 Tang8330 marked this pull request as ready for review July 3, 2025 08:56
@Tang8330 Tang8330 requested a review from a team as a code owner July 3, 2025 08:56
@Tang8330 Tang8330 merged commit 7ef55ec into master Jul 3, 2025
6 checks passed
@Tang8330 Tang8330 deleted the minor-refac branch July 3, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danafallon danafallon danafallon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tang8330 @danafallon