Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/refactor wait handler #4

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Feat/refactor wait handler #4

wants to merge 40 commits into from

Conversation

St4NNi
Copy link
Member

@St4NNi St4NNi commented Oct 25, 2024

This PR updates the wait handling logic. It also includes all changes from the reconfiguration branch and allows users to fully configure new nodes by interacting with existing ones.

Changes

  • New and updated wait_handler that duplicates less of the internal state
  • Added reconfiguration logic
  • Experimental redb storage backend for testing

lfbrehm and others added 26 commits October 11, 2024 14:32
@lfbrehm
feat: TryRecovery broadcast and replica impls
4fa711c
@lfbrehm
feat: Prepared Store for unknown event recovery
652e932
@St4NNi
chore: Fix naming add docs for recovery
7e8bfa6
@St4NNi
feat: Added/Update latest_time handling
c23310c
@St4NNi
feat: Added wait_handler forget feature
2460650
@St4NNi
feat: Draft for new wait handler
52b75ef
@lfbrehm
feat: Waithandler refactor boilerplate traits for Store
7e009df
@St4NNi
feat: Refactor waithandler
71d44c5
@St4NNi
feat: Updated waithandler to keep less state
9da1ba8
@St4NNi
chore: Remove unwraps in wait_handler
708a4f8
@St4NNi
fix: Empty deps in waithandler and already applied / commited ones
bbc9f53
@St4NNi
feat: started removing the reconfig buffer
87617d8
@St4NNi
feat: Update type signature for SyneviResult / Transaction
b546bdb
@St4NNi
refactor: Reconfiguration
35d6396
@St4NNi
refactor: Refactor status/members handling to network
def9e81
@St4NNi
fix: Wait handler incorrect state
7059cb2
@St4NNi
chore: Debug reconfiguration
d4eada5
@St4NNi
chore: Added debug for mismatched hashes
b80b324
@lfbrehm
feat: Execution & Apply as one operation
fecbc5c
@lfbrehm
fix: Get or update transaction hashes
2ba8e37
@lfbrehm
fix: Fixed wait handler dependency handling
a43279e
@lfbrehm
chore: Removed dbg prints
faa1703
@lfbrehm
feat: Performance improvements
e65f4a1
@lfbrehm
feat: Dynamic recovery timeout
c9a2db9
@St4NNi
test: Added redb_store for testing
07036eb
@St4NNi
chore: Rename stores
22a158d
@St4NNi St4NNi requested a review from lfbrehm October 25, 2024 12:51
lfbrehm
lfbrehm reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@lfbrehm lfbrehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments need to be removed and one debug print is still in the code

synevi_core/src/coordinator.rs Outdated Show resolved Hide resolved
synevi_persistence/src/lmdb_store.rs Outdated Show resolved Hide resolved
synevi_persistence/src/lmdb_store.rs Outdated Show resolved Hide resolved
synevi_persistence/src/lmdb_store.rs Outdated Show resolved Hide resolved
synevi_persistence/src/mem_store.rs Outdated Show resolved Hide resolved
synevi_persistence/src/redb_store.rs Outdated Show resolved Hide resolved
@St4NNi St4NNi requested a review from lfbrehm October 26, 2024 13:15
@St4NNi
Copy link
Member Author

St4NNi commented Oct 26, 2024

Should all be fixed by now, additionally I have put all potential blocking I/O tasks into spawn_blocking threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfbrehm lfbrehm Awaiting requested review from lfbrehm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@St4NNi @lfbrehm