Make anti-leech choker really punish underreporters #8037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artoria2e5
changed the title
We previously only prevented underreporting from working. But since we know they are underreporting, many by a factor of +Infinity, why not punish them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously only prevented underreporting from working. But since we can know some clients are underreporting, many by a factor of +Infinity, why not punish them?
The new change does just that. It divides the anti-leech score by the estimated under-reporting ratio. Of course we never estimate +Infinity because we do +1 on the divisor. Very light float32 math is used.
The comments are updated to explain the ways in which our solution differs from Chow et. al.