use scalar prob for quantile/tail ess #240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a call in ess to the prob validating function in arviz-stats in a recent PR.
For local ess it does a loop over the given probabilities and validates each but for
tail/quantile it is called directly. The validator doesn't allow single element list/array-like
and there were some cases in plot_convergence_dist` that could use that, this should make
sure a scalar is used. Being a single case where this happened I thought it was better to fix
here than to extend the validator in arviz-stats.
Edit: forgot to commit the sequence side of prob validation, arviz-devs/arviz-stats#109 combined with this should fix it
📚 Documentation preview 📚: https://arviz-plots--240.org.readthedocs.build/en/240/