Skip to content

use scalar prob for quantile/tail ess #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented May 4, 2025

I added a call in ess to the prob validating function in arviz-stats in a recent PR.
For local ess it does a loop over the given probabilities and validates each but for
tail/quantile it is called directly. The validator doesn't allow single element list/array-like
and there were some cases in plot_convergence_dist` that could use that, this should make
sure a scalar is used. Being a single case where this happened I thought it was better to fix
here than to extend the validator in arviz-stats.

Edit: forgot to commit the sequence side of prob validation, arviz-devs/arviz-stats#109 combined with this should fix it


📚 Documentation preview 📚: https://arviz-plots--240.org.readthedocs.build/en/240/

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.38%. Comparing base (352af1a) to head (15d1868).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   68.38%   68.38%           
=======================================
  Files          40       40           
  Lines        4551     4552    +1     
=======================================
+ Hits         3112     3113    +1     
  Misses       1439     1439           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OriolAbril OriolAbril marked this pull request as draft May 4, 2025 11:23
@OriolAbril OriolAbril marked this pull request as ready for review May 4, 2025 11:44
@OriolAbril OriolAbril merged commit 6404c14 into arviz-devs:main May 4, 2025
6 checks passed
@OriolAbril OriolAbril deleted the fix_ci branch May 4, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants