-
-
Notifications
You must be signed in to change notification settings - Fork 11
Explicit index support in PlotCollection.map #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
96775f3
to
96b027f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 71.02% 72.44% +1.41%
==========================================
Files 42 42
Lines 4860 4921 +61
==========================================
+ Hits 3452 3565 +113
+ Misses 1408 1356 -52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I ended up extending the behaviour to coordinate values and we internally call Faceting and aes now work from coordinate values. https://arviz-plots--241.org.readthedocs.build/en/241/tutorials/compose_own_plot.html has a demonstration of the behaviour (or will as the rtd build is still in progress as I write this). I have also solved a couple smaller issues in the process, mainly the Needs more testing and documentation (existing ones have been fixed/updated as necessary), but if there are incoming PRs it might be better to merge and add them in a follow up PR to avoid git conflicts. |
Legends also need to be fixed to adapt to the new aesthetics logic |
Legends fixed, and if I say so myself the new structure allows for much better legends without as much complexity |
5956934
to
e6cddeb
Compare
See the compose your own plot page for proof of concept.
Closes #237 and should unblock #149 (yet not fix it though as we'll still need to handle the kde/ecdf... computation through groupby for that to work completely).
Also closes #257
📚 Documentation preview 📚: https://arviz-plots--241.org.readthedocs.build/en/241/