-
-
Notifications
You must be signed in to change notification settings - Fork 11
Add savefig method to PlotCollection #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 69.02% 69.02%
=======================================
Files 41 41
Lines 4704 4727 +23
=======================================
+ Hits 3247 3263 +16
- Misses 1457 1464 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add something like
arviz-plots/src/arviz_plots/backend/none/__init__.py
Lines 103 to 110 in b57aa39
def show(chart): | |
"""Show this :term:`chart`. | |
Parameters | |
---------- | |
chart : chart_type | |
""" | |
raise TypeError("'none' backend objects can't be shown.") |
to get a more informative message if someone attempts to save a "none" backend object?
It will also make things easier when documenting as I can have a general template with the backend api and render one page per backend substituting the backend only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add some docs and merge
📚 Documentation preview 📚: https://arviz-plots--246.org.readthedocs.build/en/246/