Skip to content

Add savefig method to PlotCollection #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2025
Merged

Add savefig method to PlotCollection #246

merged 5 commits into from
May 9, 2025

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented May 7, 2025

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.02%. Comparing base (b57aa39) to head (d1ef50b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/arviz_plots/backend/bokeh/__init__.py 72.72% 3 Missing ⚠️
src/arviz_plots/backend/plotly/__init__.py 25.00% 3 Missing ⚠️
src/arviz_plots/plot_collection.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   69.02%   69.02%           
=======================================
  Files          41       41           
  Lines        4704     4727   +23     
=======================================
+ Hits         3247     3263   +16     
- Misses       1457     1464    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add something like

def show(chart):
"""Show this :term:`chart`.
Parameters
----------
chart : chart_type
"""
raise TypeError("'none' backend objects can't be shown.")

to get a more informative message if someone attempts to save a "none" backend object?

It will also make things easier when documenting as I can have a general template with the backend api and render one page per backend substituting the backend only

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add some docs and merge

@OriolAbril OriolAbril merged commit 01ae316 into main May 9, 2025
3 checks passed
@OriolAbril OriolAbril deleted the savefig branch May 9, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants