Skip to content

Add plot_rank_dist #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 14, 2025
Merged

Add plot_rank_dist #253

merged 7 commits into from
May 14, 2025

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented May 13, 2025

closes #16

This also add stats_kwargs argument to plot_rank.


📚 Documentation preview 📚: https://arviz-plots--253.org.readthedocs.build/en/253/

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2025

Codecov Report

Attention: Patch coverage is 90.64748% with 13 lines in your changes missing coverage. Please review.

Project coverage is 70.96%. Comparing base (f9d004a) to head (4337384).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/arviz_plots/plots/rank_dist_plot.py 90.97% 12 Missing ⚠️
src/arviz_plots/plots/rank_plot.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   69.30%   70.96%   +1.65%     
==========================================
  Files          41       42       +1     
  Lines        4721     4859     +138     
==========================================
+ Hits         3272     3448     +176     
+ Misses       1449     1411      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aloctavodia
Copy link
Contributor Author

Not sure how to fix the warnings. And I can't build docs locally, sphinx is giving me a "segmentation fault" (I thought I had solved this)

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left a comment to fix the docs warning.

To fix the doc build locally you might need to regenerate the env (it might have arviz-base installed from an old commit for example) so add -r when doing tox -e docs -r (after running the cleandocs job to make sure old caches aren't interfering)

@aloctavodia aloctavodia merged commit c59df92 into main May 14, 2025
3 checks passed
@aloctavodia aloctavodia deleted the rank_dist branch May 14, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add plot_rank_dist
3 participants