Skip to content

rename add_reference_lines and reference_bands #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 21, 2025
Merged

rename add_reference_lines and reference_bands #264

merged 5 commits into from
May 21, 2025

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented May 20, 2025

This also tweaks the docstrings and examples a little bit.

If you see the example with plot_forest, you will see that the band is incorrectly added to the two columns, not just the forest one. Not sure how to fix this.


📚 Documentation preview 📚: https://arviz-plots--264.org.readthedocs.build/en/264/

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.04%. Comparing base (28df7c7) to head (fcee553).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   73.04%   73.04%           
=======================================
  Files          43       43           
  Lines        5019     5019           
=======================================
  Hits         3666     3666           
  Misses       1353     1353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aloctavodia aloctavodia requested a review from OriolAbril May 20, 2025 07:15
@aloctavodia
Copy link
Contributor Author

@rohanbabbar04

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now a bit weird that the generated artists are called ref_line/ref_band but I don't really have a good alternative

@aloctavodia
Copy link
Contributor Author

Yeah, I also think is weird, but I was not able to think of a better name

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still leaving it open for a bit in case @rohanbabbar04 wants to add something

Copy link
Contributor

@rohanbabbar04 rohanbabbar04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!
I think the same question as you guys have already discussed with the names ref_line and ref_band but otherwise it looks fine.

@aloctavodia aloctavodia merged commit d52a9dc into main May 21, 2025
3 checks passed
@aloctavodia aloctavodia deleted the add_lb branch May 21, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants