-
-
Notifications
You must be signed in to change notification settings - Fork 11
rename add_reference_lines and reference_bands #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 73.04% 73.04%
=======================================
Files 43 43
Lines 5019 5019
=======================================
Hits 3666 3666
Misses 1353 1353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now a bit weird that the generated artists are called ref_line
/ref_band
but I don't really have a good alternative
Yeah, I also think is weird, but I was not able to think of a better name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still leaving it open for a bit in case @rohanbabbar04 wants to add something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
I think the same question as you guys have already discussed with the names ref_line
and ref_band
but otherwise it looks fine.
This also tweaks the docstrings and examples a little bit.
If you see the example with
plot_forest
, you will see that the band is incorrectly added to the two columns, not just theforest
one. Not sure how to fix this.📚 Documentation preview 📚: https://arviz-plots--264.org.readthedocs.build/en/264/