-
-
Notifications
You must be signed in to change notification settings - Fork 11
fixes docstring and error statement in compare function #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes docstring and error statement in compare function #267
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=======================================
Coverage 73.04% 73.04%
=======================================
Files 43 43
Lines 5019 5019
=======================================
Hits 3666 3666
Misses 1353 1353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
column_index = [c.lower() for c in cmp_df.columns] | ||
if "elpd_loo" not in column_index: | ||
|
||
elpd_method = "elpd" + "_" + rcParams["stats.information_criterion"].lower() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are dropping support for waic. We are only going to support loo.
This works import arviz_base as azb azp.plot_compare(model_compare) |
@aloctavodia okay got it, so we have to get data_frame from arviz-stats instead of arviz. I got confused because it says |
I have updated the docstring and error statement. So that users will know that they have to use compare function from arviz-stats instead of arviz |
Thanks, eventually, legacy and new versions of arviz will converge. But in the meantime, that they both exist in parallel can be confusing, so thanks for making things clear. |
In
plot_compare
, the docstring and error statement says to use arviz's compare function. While the function is compatible tocompare
function in arviz-stats. So, fixed those docstrings and error statements. So that it doesn't create any confusion.