Add Violin Plot #296
Draft
Add Violin Plot #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
- Coverage 87.82% 85.71% -2.12%
==========================================
Files 44 45 +1
Lines 5102 5249 +147
==========================================
+ Hits 4481 4499 +18
- Misses 621 750 +129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OriolAbril
reviewed
Jun 29, 2025
Comment on lines
+242
to
+245
| # flip x and y coordinates | ||
| density_flipped = left_density.rename({"plot_axis": "flipped_plot_axis"}) | ||
| density_flipped = density_flipped.assign_coords(flipped_plot_axis=["y", "x"]) | ||
| density_flipped = density_flipped.rename({"flipped_plot_axis": "plot_axis"}) |
There was a problem hiding this comment.
Suggested change
| # flip x and y coordinates | |
| density_flipped = left_density.rename({"plot_axis": "flipped_plot_axis"}) | |
| density_flipped = density_flipped.assign_coords(flipped_plot_axis=["y", "x"]) | |
| density_flipped = density_flipped.rename({"flipped_plot_axis": "plot_axis"}) | |
| # flip x and y coordinates | |
| density_flipped = left_density.sel(plot_axis=["x", "y"]).assign_coords(plot_axis=["y", "x"]) |
This should achieve the same, and adding the .sel will make it work even if for some reason the initial dataarray already has y, x as coord values
Comment on lines
+271
to
+274
| # flip x and y coordinates | ||
| density_flipped = right_density.rename({"plot_axis": "flipped_plot_axis"}) | ||
| density_flipped = density_flipped.assign_coords(flipped_plot_axis=["y", "x"]) | ||
| density_flipped = density_flipped.rename({"flipped_plot_axis": "plot_axis"}) |
There was a problem hiding this comment.
Suggested change
| # flip x and y coordinates | |
| density_flipped = right_density.rename({"plot_axis": "flipped_plot_axis"}) | |
| density_flipped = density_flipped.assign_coords(flipped_plot_axis=["y", "x"]) | |
| density_flipped = density_flipped.rename({"flipped_plot_axis": "plot_axis"}) | |
| density_flipped = left_density.sel(plot_axis=["x", "y"]).assign_coords(plot_axis=["y", "x"]) | |
| density_flipped.loc[{"plot_axis": "x"}] = -density_flipped.sel(plot_axis="x") |
You can get the data as negative like so instead of adding an argument to the visual function
| "dist", | ||
| "credible_interval", | ||
| "point_estimate", | ||
| "point_estimate_text", |
There was a problem hiding this comment.
I don't think we'll want the point estimate text in this plot, the other ones can be nice, if you haven't added it yet I don't think it is necessary you do at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress (few components remaining)
📚 Documentation preview 📚: https://arviz-plots--296.org.readthedocs.build/en/296/