-
-
Notifications
You must be signed in to change notification settings - Fork 438
Fix plot_lm handling of multidimensional data with y_model #2408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plot_lm handling of multidimensional data with y_model #2408
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2408 +/- ##
==========================================
+ Coverage 86.81% 86.84% +0.02%
==========================================
Files 124 124
Lines 12972 13007 +35
==========================================
+ Hits 11262 11296 +34
- Misses 1710 1711 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I did some changes to the tests so each test generates only one plot but the test cases are the same
4fa79b7
to
b421642
Compare
Description
Fix plot_lm functionality when using multidimensional data with y_model parameter. Previously, attempting to use plot_lm with both multidimensional y and y_model would result in dimension mismatch errors.
Also adds a test to check for the proper functioning of plot_lm when using multidimensional data with y_model parameter.
Addresses issue #1992.
Checklist
Following problematic cases in this notebook now work: https://gist.github.com/colehaus/b2aa195687f53ef7c86eec2ebb3798c2
📚 Documentation preview 📚: https://arviz--2408.org.readthedocs.build/en/2408/