Skip to content

optional normalization for psislw #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

optional normalization for psislw #2455

merged 1 commit into from
May 23, 2025

Conversation

mdmould
Copy link
Contributor

@mdmould mdmould commented May 7, 2025

Description

Adds option to not normalize log weights from Pareto smoothed importance sampling. This is useful when the scale of the weights are to be preserved (e.g., importance sampling against an unnormalized distribution).

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2455.org.readthedocs.build/en/2455/

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.79%. Comparing base (1b0b9cb) to head (d2ce305).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
arviz/stats/stats.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2455      +/-   ##
==========================================
- Coverage   86.79%   86.79%   -0.01%     
==========================================
  Files         124      124              
  Lines       12995    12998       +3     
==========================================
+ Hits        11279    11281       +2     
- Misses       1716     1717       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OriolAbril OriolAbril merged commit 5b1c4ab into arviz-devs:main May 23, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants