Convert project into workspaces #1747
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try find the relative Edit: This is good enough, I'll commit some few missing relative |
ryansuhartanto
commented
May 13, 2025
| @@ -93,7 +93,7 @@ const applyPatches = (asciidoctorCoreDependency) => { | |||
| const patchOpalCompiler = () => { | |||
| // revert https://github.com/opal/opal/commit/d46792d2160e4f524c3add711f6424dd99187d1c | |||
| // see: https://github.com/opal/opal/issues/2099 | |||
| const sourceFile = path.join(__dirname, '..', '..', 'node_modules', 'opal-compiler', 'src', 'opal-builder.js') | |||
| const sourceFile = path.join(__dirname, '..', '..', '..', '..', 'node_modules', 'opal-compiler', 'src', 'opal-builder.js') | |||
| const source = fs.readFileSync(sourceFile, 'utf8') | |||
| fs.writeFileSync(sourceFile, source.replace(/(Opal\.modules\["opal\/parser\/patch"].*?)(\s+\(function\([^)]+\) {\n\s+var self = \$klass\(\$base, \$super, 'Lexer'\);.*},\s\$Lexer_source_buffer\$eq\$1\.\$\$arity = 1\), nil\) && 'source_buffer='\n\s+}\)\(\$\$\(\$nesting, 'Parser'\), null, \$nesting\);)/gs, '$1')) | |||
| } | |||
There was a problem hiding this comment.
Should this be deleted? opal/opal#2099 is merged after all.
ggrossetie
changed the title
|
@ryansuhartanto I rebased on main but there are a few dependency issues on the CI :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #1746