fix: add null safety for tmux pane id handling #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aserowy
approved these changes
Feb 23, 2025
|
Heho, can you please add tests for these new checks? Thus, we describe the contract in these unit test further. Kind regards |
|
AND tyvm for your work! |
Tmux pane ID can be nil when inside of floating pane Signed-off-by: Tomas Slusny <[email protected]>
deathbeam
force-pushed
the
fix-pane-id
branch
from
90dfc87 to
d1daa3b
Compare
|
Added tests (had to be new one as the wrapper wasnt rly being tested before) |
aserowy
approved these changes
Feb 24, 2025
|
Tyvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tmux pane ID can be nil when inside of floating pane