-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow topaz to run as an edge authorizer #111
Conversation
Pull Request Test Coverage Report for Build 5787683224
💛 - Coveralls |
@ronenh Do you think we could maybe switch the middleware handling so it would be service type specific ? Would it make sense to add them to the constructor and expose them through the service type interface for the service host factory ? |
I think it depends on what we want to accomplish. On one hand, we want to enforce some uniformity in the middleware we use. It makes sense for the service host to be able to ensure that a well-known set of middleware is configured on all services. That could be part of the service host interface. Maybe it can be constructed with an optional list of The question then is whether we want to give individual services the ability to add their own middleware. But since users can choose to group services on ports in whatever way they choose, a service can never know who else would be affected by middleware that it adds. Unless we have a specific example of where that would be necessary, I'd opt for configuring middleware at the service host level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggested changes to be considered
Closes: #110