improvement!: 3.0 (#955)

* improvement!: use `%Ash.NotSelected{}` for unselected values

* improvement!: default `require_atomic?` to `true`

* improvement!: raise errors on unknown generic action arguments

* improvement!: default bulk strategy to `:atomic`

* improvement!: warnings on `require_atomic?` `true` actions
improvement!: revise `Ash.NotSelected` to `Ash.NotLoaded`
improvement!: errors on unknown action inputs across the board

* doc: clarify wording in notifiers.md

closes #889

* improvement!: default `api.authorization.authorize` to `:by_default`

* improvement!: require the api when constructing changesets

this commit also fixes some work from prior commits around
the default value for the `authorize` option

* improvement!: code_interface.define_for -> code_interface.api

`code_interface.define_for` is now `code_interface.api`. Additionally, it is set automatically if the `api` option is specified on `use Ash.Resource`.

* improvement!: remove registries

* improvement!: pubsub notifier default to `previous_values?: false`
improvement!: requires_original_data? callback defaults to false

* improvement!: rename Ash.Calculation -> Ash.Resource.Calculation
improvement!: improve `Ash.Query.Calculation.new` signature
improvement!: anonymous function calculations now take lists and return lists
improvement!: make callback contexts into structs
improvement!: pass context to builtin lifecycle hook changes
improvement!: calculation arguments are now in the `arguments` key of the context

* chore: fix build

* improvement!: remove `aggregates` and `calculations` from `Filter.parse` and `Filter.parse_input`

* improvement: update spark to 2.0

* improvement!: make picosat_elixir optional with `simple_sat`

* improvement!: rename api to domain

* docs: add more info to upgrading guide

* docs: tweak docs formatting

* improvement!: remove `Ash.Changeset.new!`

* docs: update docs for `Ash.Changeset.new/1`

* improvement!: deprecate `private?: false` in favor of `public?: true`

* doc: add upgrade guide for private -> public

* improvement: update reactor to 3.0

* improvement!: default `default_accept` is now `[]`

* improvement!: `Ash.CiString.new/1` returns `nil` on `nil` input

* improvement!(Ash.Reactor): Improve integration with Ash 3.0 changes.

* improvement!: clean up and reorganize `Ash` functions

this is in preparation of deprecating the functions that are defined
on the api

improvement!: remove context-based functionality

* chore: update docs references from `Ash.Domain` to `Ash`

* chore: fix bad merge

* chore: fix context access in atomic changes

* improvement!: Deprecate calling functions on (domain) api in favor of `Ash`

* improvement!: add `attribute_public?` and update `attribute_writable?` behavior

* improvement!: update atomic behaviors, default to invalid

* chore: update downcase docs

* improvement!: changeset.filters -> changeset.filter

* improvement!: remove deprecated functions

* improvement!: remove and simplify `Ash.Filter.TemplateHelpers`

* improvement: import Ash.Expr in modules where it is used
improvement: require Ash.QUery in modules where it makes sense

* fix!: keyword lists are no longer special cased in ash expressions

* improvement: add structs for more context implementations

* chore: small tweaks, finish `:all` -> `:*` conversion

* chore: update DSL docs for multitenancy.global?

* improvement: ensure selects are applied on destroys
chore: remove TODOs

* chore: some docs changes

* improvement!: introduce strict mode to calculations

* chore: update tests

* improvement: support custom expressions

* docs: document custom expressions

* chore: fix and test custom expressions and function fragments
docs: update relevant docs w/ the changes

* improvement!: reverse order of before action & before transaction hooks

* improvement!: default read actions are now paginatable

* improvement!: require explicit accept lists in default actions

* chore: update docs

* improvement!: remove Ash.Flow and Ash.Engine

* chore: unlock unused deps

* chore: don't use unused variable

* chore: include ash flow change in upgrade guide

* improvement!: standardize various exception keys and names

* improvement!: use `Splode` for errors

* improvement: update upgrade guide to include Splode

* feat: code interface on the domain

* improvement: only require primary key if resource has actions or fields
improvement: only build schema if resource has actions or fields
improvement: verify primary key in its own verifier

* improvement: add `resource/1` builtin check

* improvement!: move simple_notifiers to an option instead of a DSL builder
improvement!: update spark for better autocomplete, configure autocomplete for key functions
docs: replace `an domain` with `a domain`

* improvement: better code interface documentation

* fix: set tenant on query so that root calles to Api.aggreagte work as expected (#929)

* chore: fixes from previous improvements

* chore: update splode

* chore: update splode

* improvement!: swap position of sort order and arguments in calculation sorting

* improvement!: add `include_nil?` aggregate option, and default it to `false`

* improvement: support notifiers within actions

* improvement: support specifying multiple filters

* improvement: add `sortable?` flags to all fields
improvement: support multiple filters on relationships

* improvement: support sensitive? on calculations and arguments

* improvement: validate resources in inputs to code interface

* chore: don't require explicit accept lists when using `default_accept :*`

* chore: update spark

* chore: update public attribute handling per 3.0

* improvement: update reactor and tests

* chore: better error message

* chore: fix rebase issue

* chore: handle merge issues
improvement: don't require domain on relationships if destination has domain

* improvement!: errors on unknown inputs for calculations

* improvement: always choose to cast atomic

* improvement: support casting some embeds atomically

* improvement: various 3.0 updates, documented in upgrade.md

* chore: Add failing tests for loads with with explicit domains. (#948)

Co-authored-by: James Harton <[email protected]>

* improvement: ensure non-static dynamic domains works

* improvement: add Ash.ToTenant protocol

* chore: add docs for no ToTenant option

* fix: properly construct new query in `build/3`

* chore: update simple_sat dependency

* chore: don't reselect when missing primary keys

* chore: remove IO.inspect

* chore: update spark

* chore: update spark

* improvement: use `Keyword.put_new` in `Ash.Context.to_opts` (#953)

* improvement: support bulk and atomic operations in code interfaces

---------

Co-authored-by: James Harton <[email protected]>
Co-authored-by: WIGGLES <[email protected]>
Co-authored-by: Dmitry Maganov <[email protected]>

.check.exs

@@ -11,13 +11,8 @@
     ## ...or adjusted (e.g. use one-line formatter for more compact credo output)
     # {:credo, "mix credo --format oneline"},
 
-    {:check_formatter, command: "mix spark.formatter --check"},
     {:check_cheat_sheets, command: "mix spark.cheat_sheets --check"},
+    {:check_formatter, command: "mix spark.formatter --check"},
     {:doctor, false}
-
-    ## custom new tools may be added (mix tasks or arbitrary commands)
-    # {:my_mix_task, command: "mix release", env: %{"MIX_ENV" => "prod"}},
-    # {:my_arbitrary_tool, command: "npm test", cd: "assets"},
-    # {:my_arbitrary_script, command: ["my_script", "argument with spaces"], cd: "scripts"}
   ]
 ]

.formatter.exs

@@ -12,14 +12,13 @@ spark_locals_without_parens = [
   allow_unregistered?: 1,
   always_atomic?: 1,
   always_select?: 1,
-  api: 1,
   args: 1,
   argument: 2,
   argument: 3,
-  async?: 1,
   attribute: 1,
   attribute: 2,
   attribute: 3,
+  attribute_public?: 1,
   attribute_type: 1,
   attribute_writable?: 1,
   authorize: 1,
@@ -34,8 +33,6 @@ spark_locals_without_parens = [
   before_action?: 1,
   belongs_to: 2,
   belongs_to: 3,
-  branch: 2,
-  branch: 3,
   broadcast_type: 1,
   bypass: 1,
   bypass: 2,
@@ -52,41 +49,33 @@ spark_locals_without_parens = [
   countable: 1,
   create: 1,
   create: 2,
-  create: 3,
-  create: 4,
   create_timestamp: 1,
   create_timestamp: 2,
-  custom: 2,
   custom: 3,
   custom: 4,
-  debug: 1,
-  debug: 2,
   default: 1,
   default_accept: 1,
   default_access_type: 1,
-  default_api: 1,
   default_context: 1,
+  default_domain: 1,
   default_limit: 1,
   defaults: 1,
   define: 1,
   define: 2,
+  define?: 1,
   define_attribute?: 1,
   define_calculation: 1,
   define_calculation: 2,
-  define_for: 1,
   delay_global_validations?: 1,
   delimiter: 1,
   description: 1,
   destination_attribute: 1,
   destination_attribute_on_join_resource: 1,
   destroy: 1,
   destroy: 2,
-  destroy: 3,
-  destroy: 4,
   dispatcher: 1,
+  domain: 1,
   eager_check_with: 1,
-  entry: 1,
-  entry: 2,
   error_handler: 1,
   event: 1,
   exists: 2,
@@ -99,6 +88,7 @@ spark_locals_without_parens = [
   field_policy_bypass: 2,
   field_policy_bypass: 3,
   filter: 1,
+  filter: 2,
   filterable?: 1,
   first: 3,
   first: 4,
@@ -112,16 +102,14 @@ spark_locals_without_parens = [
   get_by: 1,
   get_by_identity: 1,
   global?: 1,
-  halt_if: 1,
-  halt_reason: 1,
   has_many: 2,
   has_many: 3,
   has_one: 2,
   has_one: 3,
   identity: 2,
   identity: 3,
   implementation: 1,
-  input: 1,
+  include_nil?: 1,
   integer_primary_key: 1,
   integer_primary_key: 2,
   join_filter: 2,
@@ -136,8 +124,6 @@ spark_locals_without_parens = [
   manual?: 1,
   many_to_many: 2,
   many_to_many: 3,
-  map: 2,
-  map: 3,
   match_other_defaults?: 1,
   max: 3,
   max: 4,
@@ -153,11 +139,10 @@ spark_locals_without_parens = [
   no_attributes?: 1,
   not_found_error?: 1,
   not_found_message: 1,
+  notifiers: 1,
   offset?: 1,
   on: 1,
-  only_keys: 1,
   only_when_valid?: 1,
-  output: 1,
   pagination: 0,
   pagination: 1,
   parse_attribute: 1,
@@ -172,18 +157,14 @@ spark_locals_without_parens = [
   primary?: 1,
   primary_key?: 1,
   private?: 1,
+  public?: 1,
   publish: 2,
   publish: 3,
   publish_all: 2,
   publish_all: 3,
   read: 1,
   read: 2,
-  read: 3,
-  read: 4,
   read_action: 1,
-  record: 1,
-  registry: 1,
-  reject: 1,
   relationship_context: 1,
   require_actor?: 1,
   require_atomic?: 1,
@@ -192,38 +173,29 @@ spark_locals_without_parens = [
   required?: 1,
   resource: 1,
   resource: 2,
-  returns: 1,
   run: 1,
-  run_flow: 2,
-  run_flow: 3,
-  select: 1,
   sensitive?: 1,
   short_name: 1,
-  simple_notifiers: 1,
   skip_global_validations?: 1,
   soft?: 1,
   sort: 1,
+  sortable?: 1,
   source: 1,
   source_attribute: 1,
   source_attribute_on_join_resource: 1,
   strategy: 1,
   sum: 3,
   sum: 4,
   table: 1,
-  tenant: 1,
   through: 1,
   timeout: 1,
   touches_resources: 1,
   trace_name: 1,
-  transaction: 2,
-  transaction: 3,
   transaction?: 1,
   type: 1,
   uniq?: 1,
   update: 1,
   update: 2,
-  update: 3,
-  update: 4,
   update_default: 1,
   update_timestamp: 1,
   update_timestamp: 2,
@@ -234,12 +206,8 @@ spark_locals_without_parens = [
   uuid_primary_key: 2,
   validate: 1,
   validate: 2,
-  validate: 3,
-  validate: 4,
   validate_destination_attribute?: 1,
   violation_message: 1,
-  wait_for: 1,
-  warn_on_empty?: 1,
   where: 1,
   writable?: 1
 ]

.github/ISSUE_TEMPLATE/proposal.md

@@ -29,7 +29,7 @@ For example
 Or
 
 ```elixir
-  Api.read(:resource, bar: 10) # <- Adding `bar` here would cause <x>
+  Ash.read(:resource, bar: 10) # <- Adding `bar` here would cause <x>
 ```
 
 **Additional context**

.github/workflows/ash-ci.yml

@@ -31,7 +31,11 @@ on:
         default: false
       hex-api-key:
         type: string
-
+      sat-solver:
+        type: string
+        default: "Picosat"
+env:
+  PG_VERSION: ${{inputs.postgres-version}}
 jobs:
   deps:
     name: mix deps.get
@@ -122,18 +126,6 @@ jobs:
         with:
           mix-env: test
           task: deps.unlock --check-unused
-
-  # Need to clean lots of things up before we can add this
-  # doctor:
-  #   name: mix doctor --full --raise
-  #   runs-on: ubuntu-latest
-  #   needs: build-test
-  #   steps:
-  #     - uses: actions/checkout@v3
-  #     - uses: team-alembic/staple-actions/actions/mix-doctor@main
-  #       with:
-  #         mix-env: test
-
   test:
     name: mix test
     runs-on: ubuntu-latest
@@ -233,7 +225,6 @@ jobs:
     needs:
       - credo
       - unused-deps
-      # - doctor
       - spark-formatter
       - spark-cheat-sheets
       - sobelow

.github/workflows/ci.yml

@@ -3,11 +3,16 @@ on:
   push:
     tags:
       - "v*"
-    branches: [main]
+    branches: [main, "3.0"]
   pull_request:
-    branches: [main]
+    branches: [main, "3.0"]
 jobs:
   ash-ci:
+    strategy:
+      matrix:
+        sat_solver: ["SimpleSat", "Picosat"]
     uses: ash-project/ash/.github/workflows/ash-ci.yml@main
     secrets:
       HEX_API_KEY: ${{ secrets.HEX_API_KEY }}
+    with:
+      sat-solver: ${{ matrix.sat_solver }}

.github/workflows/test-subprojects.yml

@@ -3,7 +3,7 @@ on:
   push:
     tags:
       - "v*"
-    branches: [main]
+    branches: [main, "3.0"]
 jobs:
   test-subprojects:
     runs-on: ubuntu-latest