generator: Replace once_cell with std::sync::LazyLock #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that this feature has been integrated into std back in Rust 1.80.0, we can avoid the dependency on the once_cell crate. There are many other crates depending on it in our dependency tree, but hopefully they’ll phase it out at some point.
Collaborator
While I agree that (Maybe you consider that to include your wider build environment with a custom invocation for the |
Ralith
approved these changes
Sep 11, 2025
Collaborator
Ralith
left a comment
Ralith
left a comment
There was a problem hiding this comment.
Cleaning up generator bitrot is always welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that this feature has been integrated into std back in Rust 1.80.0, we can avoid the dependency on the
once_cellcrate.There are many other crates depending on it in our dependency tree, but hopefully they’ll phase it out at some point.