Generate aliases for global constants #1018
Open
+68
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Nov 15, 2025
| (alt(( | ||
| value(CType::U64, tag("ULL")), | ||
| value(CType::U32, tag("U")), | ||
| // success(CType::U32), // Only for `0x1234` hexadecimals without type-suffix |
Collaborator
Author
There was a problem hiding this comment.
Was mainly "experimenting" with removing the Number and Hex variants from enum Constant because this code already handles both, but they'd end up weirdly formatted.
We have logic that doesn't append the type (ctype parsing does it by default) and interleaves the number with _.
EDIT: Though it wouldn't look out of order to just delete the 0x...u32 suffix.
| .map(|constant| generate_constant(constant)) | ||
| .collect(); | ||
|
|
||
| constants_code.push(quote! { pub const SHADER_UNUSED_NV : u32 = SHADER_UNUSED_KHR;}); |
Collaborator
Author
There was a problem hiding this comment.
I was mainly thinking about autogenerating this - but these are impossible without knowing the type through some additional bookeeping and they feel a bit useless if it isn't for vendor suffixes that might be necessary for extension stabilization going forward.
MarijnS95
force-pushed
the
vk-parse-enum
branch
from
b5dda09 to
ae06318
Compare
MarijnS95
changed the title
vk-parse
Generating aliases will help `ash` with `Vulkan-Headers` updates without causing breaking changes when extensions and their global constants are promoted (from vendor to `EXT` to `KHR` to a Vulkan feature version) where the original constant suffix is renamed or removed while a fallback **alias** is added with the old name; which our generator was ignoring thus far. One such example is `MAX_GLOBAL_PRIORITY_SIZE_KHR` which was stabilized in Vulkan 1.4 and renamed to `MAX_GLOBAL_PRIORITY_SIZE`; if we don't generate the old `_KHR`-suffixed constant as an alias to the stabilized constant that is technically a breaking change in `ash`'s release cycle. By generating these aliases we can remove one unnecessary hand-written define for `SHADER_UNUSED_NV` (which seems to have been specifically added to retain backwards compatibility).
MarijnS95
force-pushed
the
vk-parse-enum
branch
from
ae06318 to
efaeb08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating aliases will help
ashwithVulkan-Headersupdates without causing breaking changes when extensions and their global constants are promoted (from vendor toEXTtoKHRto a Vulkan feature version) where the original constant suffix is renamed or removed while a fallback alias is added with the old name; which our generator was ignoring thus far.One such example is
MAX_GLOBAL_PRIORITY_SIZE_KHRwhich was stabilized in Vulkan 1.4 and renamed toMAX_GLOBAL_PRIORITY_SIZE; if we don't generate the old_KHR-suffixed constant as an alias to the stabilized constant that is technically a breaking change inash's release cycle.By generating these aliases we can remove one unnecessary hand-written define for
SHADER_UNUSED_NV(which seems to have been specifically added to retain backwards compatibility).