Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Douyin provider #1024

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Add Douyin provider #1024

wants to merge 11 commits into from

Conversation

Loongle
Copy link
Contributor

@Loongle Loongle commented Feb 19, 2025

Add Douyin provider

image

Screenshots translated by Microsoft
image

This is Douyin, not Tiktok.

document

@kevinchalet
Copy link
Member

This is Douyin, not Tiktok.

What's the difference? Just the name/URL or is the API completely different?

FWIW, we had a similar case with Feishu/Lark in the OpenIddict repo and decided a region option was a better approach (see openiddict/openiddict-core#2097). Since the aspnet-contrib providers developed here are a lot more expensive/time-consuming to maintain, we shouldn't duplicate the Tiktok provider if it's really the same service with just a different name and URL.

@Loongle
Copy link
Contributor Author

Loongle commented Feb 19, 2025

What's the difference? Just the name/URL or is the API completely different?

Looking at the documentation so far, it seems that the API URL and the response content are inconsistent.

FWIW, we had a similar case with Feishu/Lark in the OpenIddict repo and decided a region option was a better approach (see openiddict/openiddict-core#2097). Since the aspnet-contrib providers developed here are a lot more expensive/time-consuming to maintain, we shouldn't duplicate the Tiktok provider if it's really the same service with just a different name and URL.

That's a good quote. But I can't sign up for TikTok right now. I can't test TikTok.😥
Feishu, Lark, Douyin and TikTok are all ByteDance 😅

Question: If I do compatibility processing in a package, what is the name of the package?☺️

@martincostello
Copy link
Member

You have merge conflicts.

@Loongle
Copy link
Contributor Author

Loongle commented Feb 20, 2025

Sorry, I thought that the resolution of merge conflicts should be handled by the repository maintainer.
😭

@martincostello
Copy link
Member

Sorry, I thought that the resolution of merge conflicts should be handled by the repository maintainer. 😭

I avoid doing it as if the author wants to add extra changes and don't notice the upstream has changed sometimes they get annoyed 😄

@Loongle
Copy link
Contributor Author

Loongle commented Feb 20, 2025

I avoid doing it as if the author wants to add extra changes and don't notice the upstream has changed sometimes they get annoyed 😄

This taught me some important details about open source practices. Thank you!❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants