-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Douyin provider #1024
base: dev
Are you sure you want to change the base?
Add Douyin provider #1024
Conversation
src/AspNet.Security.OAuth.Douyin/AspNet.Security.OAuth.Douyin.csproj
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Douyin/DouyinAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Douyin/DouyinAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Douyin/DouyinAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
What's the difference? Just the name/URL or is the API completely different? FWIW, we had a similar case with Feishu/Lark in the OpenIddict repo and decided a region option was a better approach (see openiddict/openiddict-core#2097). Since the aspnet-contrib providers developed here are a lot more expensive/time-consuming to maintain, we shouldn't duplicate the Tiktok provider if it's really the same service with just a different name and URL. |
Looking at the documentation so far, it seems that the API URL and the response content are inconsistent.
That's a good quote. But I can't sign up for TikTok right now. I can't test TikTok.😥 Question: If I do compatibility processing in a package, what is the name of the package? |
test/AspNet.Security.OAuth.Providers.Tests/Douyin/DouyinTests.cs
Outdated
Show resolved
Hide resolved
You have merge conflicts. |
Sorry, I thought that the resolution of merge conflicts should be handled by the repository maintainer. |
I avoid doing it as if the author wants to add extra changes and don't notice the upstream has changed sometimes they get annoyed 😄 |
This taught me some important details about open source practices. Thank you!❤️ |
Add Douyin provider
Screenshots translated by Microsoft

This is Douyin, not Tiktok.
document