-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Docling integration #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gabe-l-hart
wants to merge
9
commits into
assafelovic:master
Choose a base branch
from
gabe-l-hart:DoclingIntegration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Docling integration #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @gabe-l-hart love your contributions! Same as before, can you please update related docs? Happy to merge afterward! |
433696d
to
f65a1ff
Compare
@assafelovic Docs are updated. Thanks! |
Branch: DoclingIntegration Signed-off-by: Gabe Goodhart <[email protected]>
Branch: DoclingIntegration Signed-off-by: Gabe Goodhart <[email protected]>
Branch: DoclingIntegration Signed-off-by: Gabe Goodhart <[email protected]>
Branch: DoclingIntegration Signed-off-by: Gabe Goodhart <[email protected]>
Branch: DoclingIntegration Signed-off-by: Gabe Goodhart <[email protected]>
NOTE: The ability to invoke Granite 3.2 Vision via Ollama was added in 2.30.0, so that is the required lower bound. Branch: DoclingIntegration Signed-off-by: Gabe Goodhart <[email protected]>
Branch: DoclingIntegration Signed-off-by: Gabe Goodhart <[email protected]>
Branch: DoclingIntegration Signed-off-by: Gabe Goodhart <[email protected]>
Branch: DoclingIntegration Signed-off-by: Gabe Goodhart <[email protected]>
e6c6f3e
to
8fa64ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the local document parsing capabilities to allow the user to choose docling and optionally also use a VLM like smoldocling or granite3.2-vision for visual parsing. In addition to allowing users to choose
docling
for its output quality, this also allows users to inputpng
andjpeg
images as context.Testing
I've tested this in conjunction with my #1278 branch for a fully local LLM / VLM researcher. My two methods of testing are via a custom script and via the
nextjs
CLI.Custom Script
nextjs
FrontendI use the following env vars before running
python main.py
in the root of the repoFrom there, I've tested swapping to
hybrid
via thePreferences
panel and then dropping in a.png
screenshot to ensure it gets converted correctly.Dependencies
This PR depends on getting the next release ofdocling
out with ollama support for granite3.2-vision. I'm coordinating with @PeterStaar-IBM on that release, so it should go out soon!Ollama support for Granite Vision 3.2 in Docling was added in 2.30.0