-
Notifications
You must be signed in to change notification settings - Fork 19
Draft: Rl strategy for household #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2abd633
to
ecb724c
Compare
ecb724c
to
9822337
Compare
Add codespell to pre-commit
f28b5c3
to
d095806
Compare
@nick-harder I created a draft PR for you to have a overview of what I changed for the household.
But I face/faced two issues:
|
This should be merged on monday. This patch release fixes removing previous runs from the database. see #478
5ceb5b3
to
0ec28cc
Compare
10 tasks
a8c01fc
to
dd8d9fe
Compare
-improve handling of assumeException (when the overwrite strategies question in learning is answered with a "n") -do not access self.db before initializing the engine in on_ready -remove unrequired call for delete_similar_runs in run_learning function -move episode init back into init of output role -delete_similar_runs on start in output role when episode is 1 -clean up load_scenario_folder function as it doesn't require episode and other info any more -remove not setting up the world when episode==1 since this error no longer occurs -save last policies when exiting the loop to avoid confusion with numbering of last episode -adjust tutorial 04 as well Co-authored-by: Nick Harder <[email protected]>
f29a825
to
06527c0
Compare
f4484c1
to
3aa12cb
Compare
3aa12cb
to
18320d7
Compare
… bids (#521) Fixes the issue that a warning was raised when there were no accepted bids. This is normal behavior and should not raise a warning, as this can naturally happen. The warning is raised only of both accepted and rejected are empty
2d4e611
to
775bc06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
Closes #[issue number] (if applicable)
Description
[Provide a brief description of the changes in this PR]
Changes Proposed
Testing
[Describe the testing you've done, including any specific test cases or scenarios]
Checklist
Please check all applicable items:
doc
folder updates)pyproject.toml
doc/release_notes.rst
of the upcoming release is includedAdditional Notes (if applicable)
[Any additional information, concerns, or areas you want reviewers to focus on]
Screenshots (if applicable)
[Add screenshots to demonstrate visual changes]