Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig_analog: Add Last Number Redial feature. #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

InterLinked1
Copy link
Contributor

This adds the Last Number Redial feature to
simple switch.

UserNote: Users can now redial the last number
called if the lastnumredial setting is set to yes.

Resolves: #437

This adds the Last Number Redial feature to
simple switch.

UserNote: Users can now redial the last number
called if the lastnumredial setting is set to yes.

Resolves: asterisk#437
@InterLinked1
Copy link
Contributor Author

InterLinked1 commented Nov 10, 2023

cherry-pick-to: 20
cherry-pick-to: 21
cherry-pick-to: 22

@jcolp
Copy link
Member

jcolp commented Nov 10, 2023

Why do this here in code instead of dialplan?

@InterLinked1
Copy link
Contributor Author

InterLinked1 commented Nov 10, 2023

Why do this here in code instead of dialplan?

If immediate=no, you can't easily capture the number dialed in the dialplan. It'll start executing it immediately so you'd have to have this logic at every extension, which is a complete mess.
I do this in my own code stack normally but on a "normal" Asterisk system this is really the only elegant way to do it.

@jcolp
Copy link
Member

jcolp commented Nov 10, 2023

So yes it is possible.

@InterLinked1
Copy link
Contributor Author

So yes it is possible.

No, not really, unless you have immediate=yes, which is the scenario to which I was referring. Otherwise this is too low level to be doable in the dialplan.

@jcolp
Copy link
Member

jcolp commented Nov 10, 2023

I disagree, I believe it is reasonably possible for the usage of most users and wouldn't surprise me if others have done so. That's my opinion though and I won't stop this, others are free to join in and review this if they wish. I may eventually get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[new-feature]: sig_analog: Add Last Number Redial
2 participants