This repository was archived by the owner on Jul 27, 2023. It is now read-only.
forked from RustPython/Parser
-
Notifications
You must be signed in to change notification settings - Fork 2
Merge upstream changes for PEP695 support #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not valid syntax
* Parse type parameters in function definitions * Add test for combined items
…hon#97) Extends RustPython#95 Closes RustPython#82 Adds parsing of new `type` soft keyword for defining type aliases. Supports type alias statements as defined in PEP 695 e.g. ```python type IntOrStr = int | str type ListOrSet[T] = list[T] | set[T] type AnimalOrVegetable = Animal | "Vegetable" type RecursiveList[T] = T | list[RecursiveList[T]] ``` All type parameter kinds are supported as in RustPython#95. Builds on soft keyword abstractions introduced in RustPython/RustPython#4519
charliermarsh
approved these changes
Jul 17, 2023
Incorrectly merged LALRPOP file
zanieb
added a commit
to astral-sh/ruff
that referenced
this pull request
Jul 18, 2023
Following astral-sh/RustPython-Parser#27 we now cherry-pick commits onto our fork instead of rebasing our fork on top of the upstream which means we do not overwrite history and a tag is not necessary to preserve the pinned commit. In the future, we may rewrite the history in our fork. If we do, we should return to tagging the commits.
zanieb
added a commit
to astral-sh/ruff
that referenced
this pull request
Jul 18, 2023
Following astral-sh/RustPython-Parser#27 we now cherry-pick commits onto our fork instead of rebasing our fork on top of the upstream which means we do not overwrite history and a tag is not necessary to preserve the pinned commit. In the future, we may rewrite the history in our fork. If we do, we should return to tagging the commits.
evanrittenhouse
pushed a commit
to evanrittenhouse/ruff
that referenced
this pull request
Jul 19, 2023
) Following astral-sh/RustPython-Parser#27 we now cherry-pick commits onto our fork instead of rebasing our fork on top of the upstream which means we do not overwrite history and a tag is not necessary to preserve the pinned commit. In the future, we may rewrite the history in our fork. If we do, we should return to tagging the commits.
konstin
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Jul 19, 2023
Following astral-sh/RustPython-Parser#27 we now cherry-pick commits onto our fork instead of rebasing our fork on top of the upstream which means we do not overwrite history and a tag is not necessary to preserve the pinned commit. In the future, we may rewrite the history in our fork. If we do, we should return to tagging the commits.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following upstream pull requests to add support for PEP 695 (type alias / generics) parsing:
type
keyword RustPython/Parser#97Created by cherry-picking the upstreams' commits on top of our main branch e.g.
You can preview the commits with the
--oneline
flag e.g.We should be able to preview commits that need cherry-pick in the future with an invocation like...