Fix: Prevent matching package names starting with 'uv' in dependency parsing #490
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug introduced in #486 where packages starting with 'uv' (like 'uvicorn', 'uvloop') were incorrectly being parsed as uv version specifications.
The Problem
The current code uses
dep.startsWith("uv")
which matches any package name starting with 'uv', not just the 'uv' package itself. This causes:uvicorn==0.35.0
to be parsed asicorn==0.35.0
uvloop==0.19.0
to be parsed asloop==0.19.0
The Solution
Changed the matching logic to only match dependencies that start with 'uv' followed immediately by a version specifier character (
=
,<
,>
,~
,\!
):This ensures we only match actual 'uv' package specifications like:
uv==0.35.0
uv>=0.35.0
uv~=0.35.0
And correctly ignores other packages:
uvicorn==0.35.0
uvloop==0.19.0
uv-tool==1.0.0
Testing
The existing test with
uv==0.6.17
continues to work correctly. This fix prevents false positives from other packages.Fixes the issue reported where GitHub Actions were failing with:
Fixes: #489