Add package change summaries to uv sync json output
#16660
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Nov 10, 2025
| #[derive(Serialize, Debug, Clone)] | ||
| struct PackageChangeReport { | ||
| /// The normalized package name. | ||
| name: String, |
Member
There was a problem hiding this comment.
PackageName supports serialization, no? We shouldn't resolve to strings here unless we need to.
zanieb
reviewed
Nov 10, 2025
| action: SyncAction, | ||
| /// The packages that changed during the sync. | ||
| #[serde(default)] | ||
| packages: Vec<PackageChangeReport>, |
Member
There was a problem hiding this comment.
After looking at it... I wonder if we should call it changes? I worry packages could be confusing because it doesn't imply it's only the packages that changed
Member
There was a problem hiding this comment.
Unless we also want to enumerate all the packages that are unchanged here, with action: check... hm.
Member
|
What's your plan for dry-run? I think a clear path forward there is important to understand, even if we don't implement it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work for #16653
This PR adds a lightweight install summary to
uv sync --output-format jsonby threading the changelog returned from the pip operations into the sync report: the JSON now includes async.packagesarray detailing each added, removed, or reinstalled distribution (with version and optional source URL), so users can inspect the plan without parsing stderr.As stated in #16653, this is a preview change. We'll likely need to iterate on this in a few other changes (or keep adding onto this one).
Some ideas:
--dry-run