-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add --exclude-packages to pip compile/install/tool install
#16808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
crates/uv-cli/src/lib.rs
Outdated
| #[arg(long, alias = "exclude", env = EnvVars::UV_EXCLUDE, value_delimiter = ' ', value_parser = parse_maybe_file_path)] | ||
| pub excludes: Vec<Maybe<PathBuf>>, | ||
|
|
||
| /// Exclude the given package names from resolution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to copy the additional content from --excludes above.
When a package is excluded, it will be omitted from the dependency list entirely and its own dependencies will be ignored during the resolution phase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also just say "Exclude the given packages from resolution".
We'll often also say something like "May be provided multiple times or multiple values can be provided separated by commas"
|
I need to think a bit more about what we want long-term, i.e., if we want to go this route or something like Otherwise, this looks good! |
I'm more a fan of what you just mentioned, i.e. |
Part of #16771
This diff introduces
--exclude-packagesto pip {compile, install, tool install}, accepting comma-delimited package names (with--exclude-packageas an alias) to exclude packages without an excludes file.