Use an available python2 binary name in debian templates. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu Focal and Jammy install python2 with python-all-dev. Rather than requiring that tests and downstream packages always install python-is-python2 (seemingly unavailable on jammy), check the current path for each binary and use the first one found, preferring `python` when it is available to maintain current behavior but using `python2` if it's the only option. This unblocks testing python2 package generation with python3-stdeb in test-2and3.sh.
Although I am planning to drop support for installing/running stdeb from python2 I am hoping to preserve, at least for a while, support for generating python2 packages. Howveer, this case doesn't appear to be tested so I've added an additional case when testing python3.
nuclearsandwich
changed the title
|
Part of me feels like there might be another more explicit way to deal with this but I'm not super inclined to put more time into it as long as this works. |
cottsay
approved these changes
Jul 12, 2024
nuclearsandwich
added a commit
that referenced
this pull request
Nov 13, 2024
With the addition of #203, a missing Python 2 binary will raise an error instead of assuming that the binary is called `python`. As a result, this test script now fails on platforms where no Python 2 installation is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu Focal and Jammy install a
python2binary with python-all-dev.Rather than requiring that tests and downstream packages always install python-is-python2 (seemingly unavailable on jammy), check the current path for each binary and use the first one found, preferring
pythonwhen it is available to maintain current behavior but usingpython2if it's the only option.This unblocks testing python2 package generation with python3-stdeb in test-2and3.sh.
However, this case doesn't appear to be tested so I've added an additional case when testing python3.
Although I am planning to drop support for installing/running stdeb from python2 (#198) I am hoping to preserve, at least for a while, support for generating python2 packages using the python3 version of stdeb.