Skip to content

Remove most custom rules #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 4, 2025
Merged

Remove most custom rules #459

merged 7 commits into from
Jun 4, 2025

Conversation

paddyroddy
Copy link
Collaborator

@paddyroddy paddyroddy commented Jun 3, 2025

To simplify

@paddyroddy paddyroddy changed the title Delete .github/styles/custom/spaces.yml Remove most custom rules Jun 3, 2025
@paddyroddy paddyroddy requested a review from Copilot June 3, 2025 22:22
@paddyroddy paddyroddy self-assigned this Jun 3, 2025
@paddyroddy paddyroddy marked this pull request as ready for review June 3, 2025 22:22
Copilot

This comment was marked as outdated.

@paddyroddy paddyroddy enabled auto-merge (squash) June 3, 2025 22:23
@paddyroddy paddyroddy requested a review from Copilot June 3, 2025 22:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes most custom style and typo rules to simplify the repository configuration.

  • Deletes custom rules in .typos.toml and several .github/styles/custom/*.yml files
  • Reformats swap entries in no-contractions.yml, removing trailing commas

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.typos.toml Cleared all typo rules
.github/styles/custom/spaces.yml Emptied custom spacing rule
.github/styles/custom/quotes.yml Emptied smart quotes rule
.github/styles/custom/oxford-comma.yml Emptied Oxford comma suggestion
.github/styles/custom/no-contractions.yml Reformatted swap mapping; potential indent issue
.github/styles/custom/endash.yml Emptied en dash rule
.github/styles/custom/dashes.yml Emptied dash spacing rule
Comments suppressed due to low confidence (7)

.typos.toml:1

  • Since this file no longer contains any rules, consider deleting it entirely to avoid leaving an empty configuration file.
-[type.yaml]

.github/styles/custom/spaces.yml:1

  • This file has been emptied; removing it from the repository would prevent stale or confusing configuration.
----

.github/styles/custom/quotes.yml:1

  • With no rules left here, consider deleting the file entirely rather than keeping an empty placeholder.
----

.github/styles/custom/oxford-comma.yml:1

  • The file is now empty; remove it to avoid confusion about unused custom rules.
----

.github/styles/custom/endash.yml:1

  • This rule file has been cleared; you may want to delete it to keep the config directory clean.
----

.github/styles/custom/dashes.yml:1

  • Since all content is removed, deleting this file will prevent orphaned config files.
----

.github/styles/custom/no-contractions.yml:41

  • The you're: you are mapping is missing the list prefix (- ) and likely sits outside the swap array. Add - you're: you are to include it correctly.
you're: you are

@paddyroddy paddyroddy disabled auto-merge June 4, 2025 14:20
@paddyroddy paddyroddy merged commit 7d4fb72 into main Jun 4, 2025
19 of 20 checks passed
@paddyroddy paddyroddy deleted the paddyroddy-patch-1 branch June 4, 2025 14:20
@github-project-automation github-project-automation bot moved this from TODO to Done in @paddyroddy Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant