Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help message for actions on multi-message-selection #751

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

ibuclaw
Copy link
Contributor

@ibuclaw ibuclaw commented Jun 5, 2024

This reverts commit 8f2a8ae.

There is no other place in the code that calls rev_multi->set_reveal_child(true), so the consequence of this change was that the ; key no longer shows the revealer bar.

Before this PR:
image

After this PR:
image

proposed by @ibuclaw (Iain Buclaw <[email protected]>)
in astroidmail#738 (comment)

The missing line-wrapping lead to issues with narrow screens/window widths
(astroidmail#738).
@jorsn jorsn changed the title Revert "Fix help message breaking screen layout" Fix help message for actions on multi-message-selection Jun 29, 2024
@jorsn
Copy link
Member

jorsn commented Jun 29, 2024

last force-push was only a change to the commit message

@jorsn jorsn merged commit bd0cd0c into astroidmail:master Jun 29, 2024
6 checks passed
@ibuclaw ibuclaw deleted the revert_8f2a8ae branch June 29, 2024 18:11
@jorsn
Copy link
Member

jorsn commented Jul 31, 2024

@zxramozx Could you explain what this means and what it has to do with this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants