Skip to content

Set margin_top on the revealer bars in addition to margin_bottom#752

Merged
jorsn merged 2 commits intoastroidmail:masterfrom
ibuclaw:fix_revealer_margins
Jun 18, 2024
Merged

Set margin_top on the revealer bars in addition to margin_bottom#752
jorsn merged 2 commits intoastroidmail:masterfrom
ibuclaw:fix_revealer_margins

Conversation

@ibuclaw
Copy link
Contributor

@ibuclaw ibuclaw commented Jun 5, 2024

  1. Sets equal margins on both top and bottom, which (to me) has a better aesthetic look to it.
  2. I noticed that there was a typo in the code which meant the bulk update ("multi") revealer never got a margin set.

Before this PR:

image

image


After this PR:

image

image


@ibuclaw
Copy link
Contributor Author

ibuclaw commented Jun 5, 2024

After a little toying around, I've convinced myself that a slightly smaller margin for the yes/no buttons looks better.

Updated "After" screenshot:

image

@jorsn
Copy link
Member

jorsn commented Jun 18, 2024

Thanks!

@jorsn jorsn merged commit 8426f72 into astroidmail:master Jun 18, 2024
@ibuclaw ibuclaw deleted the fix_revealer_margins branch June 18, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants