Use preferred string format for globbing. #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
=======================================
Coverage 99.35% 99.35%
=======================================
Files 24 24
Lines 1238 1238
=======================================
Hits 1230 1230
Misses 8 8 ☔ View full report in Codecov by Sentry. |
smcguire-cmu
approved these changes
May 1, 2024
smcguire-cmu
requested changes
May 1, 2024
smcguire-cmu
approved these changes
May 1, 2024
delucchi-cmu
added a commit
to regro-cf-autotick-bot/hipscat-import-feedstock
that referenced
this pull request
Jun 3, 2024
Use fsspec version from hipscat. Unpin. see astronomy-commons/hats-import#291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See astronomy-commons/lsdb#294
See astronomy-commons/hats#265
The
"**"path part is only supported in the newest fsspec versions as an "entire path component", so it's ok to say/match/like/**/but not/match/like/**.csv. This should work with older and newer fsspec versions, and so once the change is released for only newer fsspec versions, this package should be ok.