Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __getitem__ accessor for catalogs #281

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

smcguire-cmu
Copy link
Contributor

@smcguire-cmu smcguire-cmu commented Apr 19, 2024

Allows accessing catalog through square brackets by overloading __getitem__ to pass through to the Dask DataFrame and covert result to catalog if necessary.

Closes #251

Copy link

github-actions bot commented Apr 19, 2024

Before [3b245e1] After [8180f79] Ratio Benchmark (Parameter)
37.1±1ms 37.8±0.5ms 1.02 benchmarks.time_kdtree_crossmatch
14.3±0.8ms 14.6±0.8ms 1.02 benchmarks.time_polygon_search
6.08±0.2ms 6.03±0.2ms 0.99 benchmarks.time_box_filter_on_partition

Click here to view all benchmarks.

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (3b245e1) to head (1fc6792).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files          41       41           
  Lines        1255     1260    +5     
=======================================
+ Hits         1242     1247    +5     
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit 286fa7a into main Apr 22, 2024
11 checks passed
@delucchi-cmu delucchi-cmu deleted the sean/catalog-accessor branch April 22, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog Accessors
2 participants