Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use faster hipscat paths method #284

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Use faster hipscat paths method #284

merged 2 commits into from
Apr 24, 2024

Conversation

smcguire-cmu
Copy link
Contributor

Changes the abstract catalog loader to use the new hipscat method to get multiple paths introduced in astronomy-commons/hats#258

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (12ec915) to head (fa9288e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files          41       41           
  Lines        1264     1264           
=======================================
  Hits         1251     1251           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 23, 2024

Before [12ec915] After [4f5ae31] Ratio Benchmark (Parameter)
5.49±0.3ms 5.82±0.3ms 1.06 benchmarks.time_box_filter_on_partition
33.8±0.5ms 34.9±0.5ms 1.03 benchmarks.time_kdtree_crossmatch
13.9±0.8ms 12.9±0.4ms 0.93 benchmarks.time_polygon_search

Click here to view all benchmarks.

@smcguire-cmu smcguire-cmu merged commit 80a7b2c into main Apr 24, 2024
11 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/paths branch April 24, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants