Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test can be unskipped for column names with spaces #501

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Nov 14, 2024

lincc-frameworks/nested-pandas#174 has been closed.

Columns names which contain spaces and other special characters are now supported (even if they'd be weird).

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (aaf065f) to head (d3a77d2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #501   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files          39       39           
  Lines        1540     1540           
=======================================
  Hits         1504     1504           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [aaf065f] After [2cc871e] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_polygon_search
16.1±0.4ms 17.3±0.3ms 1.07 benchmarks.time_box_filter_on_partition
99.7±0.9ms 105±0.9ms 1.05 benchmarks.time_kdtree_crossmatch
14.5±0.03s 14.6±0.05s 1.01 benchmarks.time_create_large_catalog
2.16±0.03s 2.16±0.02s 1.00 benchmarks.time_create_midsize_catalog

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu changed the title Should be fixed Test can be unskipped for column names with spaces Nov 14, 2024
@delucchi-cmu delucchi-cmu merged commit 0e72af7 into main Nov 14, 2024
11 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/unskip branch November 14, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants