Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: cleanup test data #2342

Merged
merged 5 commits into from
Apr 15, 2022
Merged

MNT: cleanup test data #2342

merged 5 commits into from
Apr 15, 2022

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Mar 29, 2022

I was running into some discrepancies while investigating the current CI failure (#2250 (comment)).

I've left alone two recently added, but yet unused test files as adding more testing is in the near future plans for that module (#2328 (comment))

@bsipocz
Copy link
Member Author

bsipocz commented Mar 29, 2022

There are more to come, these are only the ones picked up by missing from the MANIFEST collection.

@bsipocz
Copy link
Member Author

bsipocz commented Mar 29, 2022

OK, this is ready now. I haven't run remote tests on these changes, but we ideally should do that before merging to see nothing got broken due to these clearups.

@bsipocz
Copy link
Member Author

bsipocz commented Mar 29, 2022

I've run the remote tests and none of them seems to be new and due to the changes in this PR (it's a bit difficult to say it for certain as the test suite runs for ~2hrs and has 41 failures, some of which are temporary flukes, etc.)

@bsipocz bsipocz force-pushed the MNT_test_data_fixes branch from b416af5 to e51d3ee Compare April 15, 2022 16:56
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #2342 (e51d3ee) into main (c081ee4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2342   +/-   ##
=======================================
  Coverage   63.40%   63.40%           
=======================================
  Files         131      131           
  Lines       17044    17044           
=======================================
  Hits        10807    10807           
  Misses       6237     6237           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bsipocz bsipocz merged commit f9552ca into astropy:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants