-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linelists: make lookuptables a little more robust #2901
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
==========================================
- Coverage 67.23% 67.23% -0.01%
==========================================
Files 235 235
Lines 18155 18159 +4
==========================================
+ Hits 12207 12209 +2
- Misses 5948 5950 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for the case you detailed out in the PR description, and maybe a short changelog, too?
|
||
""" | ||
|
||
if s in self: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, my eyes hurt, could we make this called something longer than s? I suspect that would mean a deprecation--rename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we renamed it to st
in the other instance. But this particular argument is barely user-facing; I don't know that we need to deprecate it
This should probably go into a slightly larger refactor too:
|
The lookuptables used in linelist searches are a little touchy because of lines like
HCO+
andHOCO+
. You have to escape the+
's to get them to work, which means that even exact matches to molecules, like29002 HCO+ v=0,1,2
will not work.This change means that exact matches will work, while partial matches will still need to be escaped.