ESA Integral Science Legacy Archive Astroquery module

[jespinosaar]

Dear Astroquery team,

This PR aims to integrate a new module for the ESA Integral Science Legacy Archive. The main difference with other modules is that this is the first integration of an ESA module using PyVO, instead of the deprecated astroquery.utils.tap module. We have developed a fully functional module that can be used as reference to migrate the rest. Please let us know your thoughts and we will iterate on this to merge it. Thanks for your support!

Would it be possible to create a release, right after this module has been merged? Thank you very much.

Kind regards,

@jespinosaar

cc @esdc-esac-esa-int

[pep8speaks]

Hello @jespinosaar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-12-19 08:43:26 UTC

[jespinosaar]

Ok, the tests are not working in the CI/CD environment. It seems that, at some point, it tries to connect to the URL. I would need some support on this. Maybe I should define the tap parameter as a property, similar to what is done for other modules. What do you think, @bsipocz ? Do you recommend any other alternative?

[codecov]

Codecov Report

Attention: Patch coverage is 82.57426% with 88 lines in your changes missing coverage. Please review.

Project coverage is 67.94%. Comparing base (cc279d5) to head (af9d8e6).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
astroquery/esa/utils/utils.py	59.86%	59 Missing ⚠️
astroquery/esa/integral/core.py	91.39%	29 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3154      +/-   ##
==========================================
+ Coverage   67.54%   67.94%   +0.39%     
==========================================
  Files         233      235       +2     
  Lines       18493    18998     +505     
==========================================
+ Hits        12491    12908     +417     
- Misses       6002     6090      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jespinosaar]

I applied the changes I commented before and it seems all checks are passing now! So we can now check if everything is ok, iterate on changes and, when possible, merge it. Please let me know your thoughts and thanks in advance for the feedback!

[bsipocz]

Thanks @jespinosaar. I'll bump this into the new year as it's unrealistic to promise a review before we're off for a break.

[jespinosaar]

Of course, no problem! thanks @bsipocz and Merry Christmas!