Force little endian input for zarr #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes CI test failures on bigendian machines like s390x.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
=======================================
Coverage 91.00% 91.00%
=======================================
Files 25 25
Lines 1078 1078
=======================================
Hits 981 981
Misses 97 97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for the PR! I am first going to try and add a big-endian CI job to try and catch this kind of issue in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I found the cause for the failures in #491: One is what was already mentioned in #487 (review), and the other is similar in
reproject/common.py. The reason why the patch shown in #491 didn't work was that the second patch inreproject/utils.pywas actually wrong.I applied this PR to the Debian package (merged with #487), and now all tests pass on s390x.
Disclaimer: This is a fix by a "poor stranger". I didn't dig into the structure of reproject for this but just fixed what could cause the failures. There may be other places with a similar issue, or side effects that are not covered by the CI tests. So, please carefully review whether this does what is intended, beside the CI.
Closes: #491