Updates the sdss mwmStar loader to fix bug with file datasums #1253
+31
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SDSS-V mwm data loaders to account for a bug in a subset of the DR19 SDSS-V mwmStar files. A subset of files have extensions with empty data arrays and non-zero DATASUM keywords. This was due to some data needing to be cleaned out but the header wasn't fully scrubbed/corrected.
The previous loader would attempt to load first extension found with non-zero DATASUM and would crash on the empty data. This fix allows the loader to correctly skip over it and load the first real data extension it finds.
It would be great if this can be backported to
specutils 1.x
, so it can be used currently in Jdaviz.