Add linear and loglinear wavelength solutions to (IRAF) fits-wcs #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds linear and log-linear solutions to IRAF MULTISPEC format. Since the implementation is shares with the simpler IRAF formats (which had only linear, but not log-linear before), they gain the log-linear solutions as well. This is one step towards astropy#229. The MUTLISPEC format is often used for echelle spectra and linear solutions for that are common in the wild (e.g. KECK HIRES pipeline).
With this change, a test that previously raised a NotImpelementedError now passes. Also, formatting changes to make the linter happy.
hamogu
force-pushed
the
io_multispec_linear
branch
from
1e00159 to
667f11d
Compare
|
Thanks for the contribution, I haven't gotten a chance to look at the code yet but I'll review and get this in before the next release (hopefully later this week or early next week). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds linear and log-linear solutions to IRAF MULTISPEC format. Since the implementation is shares with the simpler IRAF formats (which had only linear, but not log-linear before), they gain the log-linear solutions as well.
This is one step towards #229. The MUTLISPEC format is often used for echelle spectra and linear solutions for that are common in the wild (e.g. KECK HIRES pipeline).