Update WCS when shifting spectrum and fix bugs with arithmetic and redshift #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
added
bug
data objects
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
=======================================
Coverage 86.94% 86.95%
=======================================
Files 63 63
Lines 4873 4891 +18
=======================================
+ Hits 4237 4253 +16
- Misses 636 638 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keflavich
reviewed
Nov 29, 2025
keflavich
reviewed
Nov 29, 2025
Contributor
Author
|
Test failures are unrelated timeouts. |
rosteen
force-pushed
the
no-redshift-arithmetic
branch
from
07cc017 to
8e472c4
Compare
rosteen
force-pushed
the
no-redshift-arithmetic
branch
from
8e472c4 to
b96dc77
Compare
keflavich
reviewed
Dec 8, 2025
More min version updates More oldestdeps update More pinning...
rosteen
force-pushed
the
no-redshift-arithmetic
branch
from
3b21bf5 to
f5ab161
Compare
Contributor
Author
|
@keflavich I added the comment you suggested, and also improved test coverage and addressed a couple problems that revealed (mainly that I forgot to update CDELT and that PCx_x will only be there for multidimensional spectra). |
cshanahan1
approved these changes
Dec 12, 2025
Contributor
cshanahan1
left a comment
cshanahan1
left a comment
There was a problem hiding this comment.
looks reasonable to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1268, and additionally improves the behavior of the
shift_spectrum_tomethod.Previously, the spectral axis was updated when applying a redshift with
shift_spectrum_to, but the original WCS was kept on theSpectrum, which led to some annoying behavior and workarounds (and was potentially confusing to the user). Now the WCS will be updated along with the spectral axis - in the case of a FITS WCS, the relevant header values will be updated in place, while a GWCS will be replaced with a new lookup table GWCS. In the latter case, the original WCS will be stored in an_original_wcsattribute so no information is lost (e.g., spatial coordinates for a cube). This obviously isn't an ideal solution for the GWCS case but I hope it suffices while I investigate better ways to handle the GWCS case.