docs: rewrite tutorial for template based on AsyncAPI v3 #1525
Conversation
Aditya08Vashisht
requested review from
Florence-Njeri,
derberg,
asyncapi-bot-eve,
magicmatatjahu and
jonaslagoni
as code owners
|
|
Warning Rate limit exceeded@Aditya08Vashisht has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 20 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis change removes multiple configuration, manifest, and documentation files related to the AsyncAPI generator project, including its core generator logic and parser modules. It also introduces new documentation assets: a minified CSS file and an HTML documentation page for the Temperature Service. Additionally, the AsyncAPI tutorial example is updated from version 2.6.0 to 3.0.0, reflecting the AsyncAPI v3 specification. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation (index.html)
participant CSS (asyncapi.min.css)
User->>Documentation: Open docs/index.html
Documentation->>CSS: Load asyncapi.min.css for styling
Documentation->>User: Render navigation and AsyncAPI v3-based content
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
apps/generator/docs/generator-template.md (1)
6-15: 🛠️ Refactor suggestionInconsistent tutorial narrative vs. example content
The intro (lines 6–15) still talks about monitoring bedroom AC temperature, but the YAML example (starting at line 45) now uses a Comments Service. Please revise the narrative to match the Comments Service context.🧰 Tools
🪛 LanguageTool
[style] ~14-~14: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... the MQTT client in this project. - You'll create a React template that will us...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
🧹 Nitpick comments (5)
apps/generator/docs/generator-template.md (2)
57-86: Channels restructured for AsyncAPI v3.0.0
You’ve correctly replaced inline operations withaddress+messagesmaps, referencing component schemas for payloads.
- Nit: Line 81 has a typo: “recived” → “received.”
106-129: Component schemas defined
Centralizing schemas (commentCount,commentReaction,count,commentId) is good. Please verify consistent 2-space indentation and add a newline at EOF.apps/generator/test/docs/ws.yml (3)
27-35: Typo in message description
Line 32 reads “Message that is being recived…”; please correct “recived” → “received.”
54-72: Centralized component schemas
DefiningcommentCount,commentReaction,count, andcommentIdundercomponents.schemasis exact. Consider marking key properties asrequiredfor stronger schema validation.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 59-59: wrong indentation: expected 8 but found 7
(indentation)
[warning] 60-60: wrong indentation: expected 9 but found 8
(indentation)
[error] 72-72: no new line character at the end of file
(new-line-at-end-of-file)
72-72: Ensure newline at EOF
Add a trailing newline so the file ends with\n, preventing parser warnings.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 72-72: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.eslintignore(0 hunks)apps/generator/docs/generator-template.md(1 hunks)apps/generator/package.json(0 hunks)apps/generator/test/docs/ws.yml(1 hunks)turbo.json(0 hunks)
💤 Files with no reviewable changes (3)
- .eslintignore
- apps/generator/package.json
- turbo.json
🧰 Additional context used
🪛 YAMLlint (1.35.1)
apps/generator/test/docs/ws.yml
[warning] 59-59: wrong indentation: expected 8 but found 7
(indentation)
[warning] 60-60: wrong indentation: expected 9 but found 8
(indentation)
[error] 72-72: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (7)
apps/generator/docs/generator-template.md (3)
45-53: AsyncAPI version bump and service metadata
Updating toasyncapi: 3.0.0and renaming the service to “Comments Service” correctly aligns the example with AsyncAPI v3.0.0.
54-56: Server definition update
Switching from aurlfield tohost: test.mosquitto.orgunderservers.devmatches the v3.0.0 spec. Ensure the prose above explains this change.
87-105: Top-level operations section introduced
The newoperations:block properly maps actions (send/receive) to channels via$ref. This conforms to AsyncAPI v3.0.0 conventions.apps/generator/test/docs/ws.yml (4)
1-5: Upgrade to AsyncAPI v3.0.0 and update metadata
Switchingasyncapi: 3.0.0, updatinginfo.titleto “Comments Service”, and refining the description correctly reflects the new spec.
7-9: Server config adjusted for MQTT
Replacing the WebSocket server withhost: test.mosquitto.organdprotocol: mqttis accurate for your MQTT-based example.
11-18: Publish channels defined with component refs
sendCommentLiked(and similarlysendCommentUnliked) correctly usesaddress,messages, and payload$refto component schemas.
37-45: Operations section added
The newoperations:block properly maps each action (send/receive) to its channel via$ref, aligning with AsyncAPI v3.0.0.
|
@coderabbitai[bot] you are very much right that i jut forgot to make the efficient changes for parser api usage that you clearly identified and confirmed to me.. give me some time and I'll be doing the need full in the same PR most probably |
|
Tip For best results, initiate chat on the files or code changes. @Aditya08Vashisht Thank you for acknowledging this! You're right, while the AsyncAPI document examples have been nicely updated to v3.0.0, the code that interacts with the parser API still needs to be updated to be compatible with the v3 format. I appreciate that you plan to address this in the same PR. If you need any assistance with implementing the parser API updates, feel free to let me know. I'm happy to help review your changes or provide guidance on the v3 parser API usage. Looking forward to seeing your updates! 🐰 |
|
@coderabbitai[bot] I hope no other thing than this parser thing is now left and also i deleted some unncecassary files like package.json and turbo.json etc.. also additionally can i ask you some general and tech Qs about this generator repo..? |
|
Tip For best results, initiate chat on the files or code changes. @Aditya08Vashisht Thanks for the update! Regarding the parser API updates, that does seem to be the main outstanding item based on our previous discussion. I noticed you mentioned deleting package.json and turbo.json as "unnecessary" files. These files are typically important in Node.js projects - package.json contains your dependencies and scripts, while turbo.json configures build pipelines in monorepos. Were these files moved elsewhere or determined to be redundant in the repository structure? Just want to make sure this won't cause issues. I'd be happy to answer general and technical questions about the generator repository! Feel free to ask anything specific about the codebase, architecture, or functionality, and I'll do my best to help based on what I can see in the repository. |
|
@coderabbitai[bot] but are these files important to include in regards to this issue.? what do you think totally? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@Aditya08Vashisht Let me check the details of issue #1503 and the repository structure to give you a proper assessment of whether those configuration files are important for this specific issue. 🏁 Script executed: Length of output: 2628 @Aditya08Vashisht After checking the repository structure and issue #1503, I have some thoughts about the deleted files:
For this specific issue, I'd recommend focusing on updating the tutorial content and parser API usage for AsyncAPI v3, which appears to be the core of issue #1503. Removing configuration files like package.json seems outside the scope of this specific task unless they were directly related to the tutorial itself. What specific package.json file did you remove? Was it the root one or one in a subdirectory? |
|
@coderabbitai[bot] what my thoughts are that i implemented these files in previous commit for another PR of different issue somehow they came included when i was making this PR IDK why and how? so feels that they are totally unneccesary! |
|
Tip For best results, initiate chat on the files or code changes. @Aditya08Vashisht Ah, that explains it! It sounds like you have a Git branch management situation here. Files from one branch/PR can sometimes get mixed into another if the branches weren't completely separated or if you created the new branch from one that already had those changes. If those files (package.json and turbo.json) were meant for a different PR and shouldn't be part of this one, then you're right to remove them. This will keep the PR focused specifically on the AsyncAPI v3 tutorial update, which is the scope of issue #1503. For this PR, the most important thing is to focus on:
Let me know if you need any help with the parser API updates or if you have other questions about the generator repository! |
| operationId: temperatureChange | ||
| message: | ||
| description: Message that is being sent when the temperature in the bedroom changes. | ||
| sendCommentLiked: |
There was a problem hiding this comment.
Hey @Aditya08Vashisht here @derberg has said to migrate the asyncapi document given in the tutorial to v3. It was just an example that he gave you to take as base. Not that you have to use it. It was just for understanding the changes between v2 and v3.
There was a problem hiding this comment.
okay I understand all my petty mistakes will do all the needful updations required by this issue as earliest as possible.
| "rimraf": "^3.0.2", | ||
| "unixify": "^1.0.0" | ||
| } | ||
| } |
There was a problem hiding this comment.
why do you delete this file?
There was a problem hiding this comment.
Actually this fie was my previous issue contibution and somehow it came in this PR
Hence was totally unnecessary for the issue.
| "outputs": ["assets/**"] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
same is the case with this file as well.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/css/global.min.css (1)
1-1: False positive: duplicate font names
The Biome lint warning about redundant “Segoe” entries can be ignored here—Segoe UIandSegoe UI Emojiare distinct font families used for proper fallback. No change is required in this minified stylesheet.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: Duplicate font names are redundant and unnecessary: Segoe
Remove duplicate font names within the property
(lint/suspicious/noDuplicateFontNames)
docs/css/asyncapi.min.css (1)
5-5: False positive: duplicate font names
Although the static analysis flags duplicate “Segoe”, this rule list intentionally includesSegoe UI,Segoe UI Emoji, andSegoe UI Symbolfor complete font fallback support. You can safely ignore the warning in this generated file.🧰 Tools
🪛 Biome (1.9.4)
[error] 5-5: Duplicate font names are redundant and unnecessary: Segoe
Remove duplicate font names within the property
(lint/suspicious/noDuplicateFontNames)
[error] 5-5: Duplicate font names are redundant and unnecessary: Segoe
Remove duplicate font names within the property
(lint/suspicious/noDuplicateFontNames)
[error] 5-5: Duplicate font names are redundant and unnecessary: Segoe
Remove duplicate font names within the property
(lint/suspicious/noDuplicateFontNames)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/js/asyncapi-ui.min.jsis excluded by!**/*.min.js
📒 Files selected for processing (6)
apps/generator/docs/comments-service.v3.yml(1 hunks)apps/generator/docs/generator-template.md(1 hunks)docs/css/asyncapi.min.css(1 hunks)docs/css/global.min.css(1 hunks)docs/index.html(1 hunks)docs/js/app.js(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- apps/generator/docs/comments-service.v3.yml
- docs/js/app.js
- docs/index.html
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/generator/docs/generator-template.md
🧰 Additional context used
🪛 Biome (1.9.4)
docs/css/asyncapi.min.css
[error] 5-5: Duplicate font names are redundant and unnecessary: Segoe
Remove duplicate font names within the property
(lint/suspicious/noDuplicateFontNames)
[error] 5-5: Duplicate font names are redundant and unnecessary: Segoe
Remove duplicate font names within the property
(lint/suspicious/noDuplicateFontNames)
[error] 5-5: Duplicate font names are redundant and unnecessary: Segoe
Remove duplicate font names within the property
(lint/suspicious/noDuplicateFontNames)
docs/css/global.min.css
[error] 1-1: Duplicate font names are redundant and unnecessary: Segoe
Remove duplicate font names within the property
(lint/suspicious/noDuplicateFontNames)
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (4)
apps/generator/lib/generator.js (1)
36-36: Remove stale commented-out importThe commented line no longer serves a purpose and adds noise to the file. Please delete it to keep the import section clean.
-//const { parse, deref } = require('@asyncapi/parser');apps/generator/test/asyncapi.yml (2)
59-60: Fix indentation forcommentCountschema properties.The
commentIdandcountentries undercomponents.schemas.commentCount.propertiesare misaligned. They need one additional space to comply with YAML structure and AsyncAPI expectations.components: schemas: commentCount: type: object additionalProperties: false properties: - commentId: - $ref: '#/components/schemas/commentId' - count: - $ref: '#/components/schemas/count' + commentId: + $ref: '#/components/schemas/commentId' + count: + $ref: '#/components/schemas/count'🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 59-59: wrong indentation: expected 8 but found 7
(indentation)
[warning] 60-60: wrong indentation: expected 9 but found 8
(indentation)
72-72: Ensure newline at end of file.YAML files should end with a newline character to satisfy POSIX standards and avoid parser warnings.
# (end of file) +🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 72-72: no new line character at the end of file
(new-line-at-end-of-file)
apps/generator/docs/parser.md (1)
10-10: Remove trailing punctuation in heading.The trailing colon in the heading violates markdownlint rule MD026 (no-trailing-punctuation). Removing it enhances consistency.
-### ✅ Supported schema formats: +### ✅ Supported schema formats🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
10-10: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
apps/generator/docs/parser.md(1 hunks)apps/generator/lib/generator.js(1 hunks)apps/generator/lib/parser.js(1 hunks)apps/generator/test/asyncapi.yml(1 hunks)apps/generator/test/testParser.js(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
apps/generator/lib/generator.js (2)
apps/generator/test/testParser.js (2)
parse(17-17)rawSpec(7-7)apps/generator/lib/parser.js (1)
derefDoc(33-33)
🪛 markdownlint-cli2 (0.17.2)
apps/generator/docs/parser.md
10-10: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
🪛 YAMLlint (1.35.1)
apps/generator/test/asyncapi.yml
[warning] 59-59: wrong indentation: expected 8 but found 7
(indentation)
[warning] 60-60: wrong indentation: expected 9 but found 8
(indentation)
[error] 72-72: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (1)
apps/generator/docs/parser.md (1)
8-8: Well-articulated parser introduction.The new description concisely highlights the parser’s multi-environment support and validation capabilities. Nicely done!
apps/generator/lib/parser.js
Outdated
| const derefDoc = await deref(document); // ✅ this is key | ||
| const correctDocument = this.getProperApiDocument(document, generator.templateConfig); | ||
| return {document: correctDocument, diagnostics}; | ||
|
|
||
| return {document: derefDoc, diagnostics}; |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
deref is missing, unused variable, and conversion now skipped
derefis called but never imported – runtime will crash withReferenceError.correctDocumentis computed but never used.- By returning
derefDocdirectly you removed the API-version conversion (getProperApiDocument) that templates depending on v1 still need.
Fix suggestion:
+const { deref } = require('@asyncapi/parser'); // add once at top of file
...
-const derefDoc = await deref(document); // ✅ this is key
-const correctDocument = this.getProperApiDocument(document, generator.templateConfig);
-
-return {document: derefDoc, diagnostics};
+const derefDoc = await deref(document);
+const converted = this.getProperApiDocument(derefDoc, generator.templateConfig);
+return { document: converted, diagnostics };Additionally, consider converting parse to a normal function (instead of an arrow) so that this reliably refers to the exported parser object.
🏁 Script executed:
#!/bin/bash
set -eux
# Display the top of parser.js to check imports and function definitions
sed -n '1,60p' apps/generator/lib/parser.js
# Display lines around 30-60 to include the snippet and context
sed -n '30,60p' apps/generator/lib/parser.jsLength of output: 3554
Add missing deref import and return the properly converted document
The parser currently calls deref(document) without importing it, never uses the correctDocument variable, and skips the API‐version conversion on the dereferenced document. Update as follows:
• In apps/generator/lib/parser.js:
– Import deref from @asyncapi/parser.
– In parser.parse, call getProperApiDocument on derefDoc and return that.
– Remove the unused correctDocument variable.
Suggested diff:
--- a/apps/generator/lib/parser.js
+++ b/apps/generator/lib/parser.js
@@ 1,5c1,6
- const { convertToOldAPI } = require('@asyncapi/parser');
+ const { convertToOldAPI, deref } = require('@asyncapi/parser');
const { ConvertDocumentParserAPIVersion, NewParser } = require('@asyncapi/multi-parser');
@@ parser.parse = async (asyncapi, oldOptions, generator) => {
- const derefDoc = await deref(document); // ✅ this is key
- const correctDocument = this.getProperApiDocument(document, generator.templateConfig);
-
- return {document: derefDoc, diagnostics};
+ const derefDoc = await deref(document);
+ // preserve API‐version conversion on the dereferenced document
+ const converted = this.getProperApiDocument(derefDoc, generator.templateConfig);
+ return { document: converted, diagnostics };📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const derefDoc = await deref(document); // ✅ this is key | |
| const correctDocument = this.getProperApiDocument(document, generator.templateConfig); | |
| return {document: correctDocument, diagnostics}; | |
| return {document: derefDoc, diagnostics}; | |
| const derefDoc = await deref(document); | |
| // preserve API‐version conversion on the dereferenced document | |
| const converted = this.getProperApiDocument(derefDoc, generator.templateConfig); | |
| return { document: converted, diagnostics }; |
apps/generator/test/testParser.js
Outdated
| const { parse } = require('./apps/generator/lib/parser'); // Adjust path if needed | ||
| const { usesNewAPI, getProperApiDocument } = require('./apps/generator/lib/parser'); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Broken relative import path
testParser.js resides in apps/generator/test/, therefore
require('./apps/generator/lib/parser') resolves to
apps/generator/test/apps/generator/lib/parser (does not exist). Use a
relative parent path instead and merge the two requires:
-const { parse } = require('./apps/generator/lib/parser'); // Adjust path if needed
-const { usesNewAPI, getProperApiDocument } = require('./apps/generator/lib/parser');
+const {
+ parse,
+ usesNewAPI,
+ getProperApiDocument
+} = require('../lib/parser');📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const { parse } = require('./apps/generator/lib/parser'); // Adjust path if needed | |
| const { usesNewAPI, getProperApiDocument } = require('./apps/generator/lib/parser'); | |
| const { | |
| parse, | |
| usesNewAPI, | |
| getProperApiDocument | |
| } = require('../lib/parser'); |
apps/generator/test/asyncapi.yml
Outdated
| Message that is being recived with the total number of views in a | ||
| comment. |
There was a problem hiding this comment.
Fix typo in channel description.
The word "recived" is misspelled in the receiveCommentViews channel description; it should be "received".
description: >-
- Message that is being recived with the total number of views in a
+ Message that is being received with the total number of views in a📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Message that is being recived with the total number of views in a | |
| comment. | |
| description: >- | |
| Message that is being received with the total number of views in a | |
| comment. |
|
Tip For best results, initiate chat on the files or code changes. @Aditya08Vashisht Thanks for sharing the test output! I see the parser is working correctly, which is great. Since these files (example-asyncapi.yml and test-parser.js) were only added for your testing purposes and aren't part of the actual PR deliverables for issue #1503, I would suggest:
Either way, the important part is that your parser updates are working correctly, which is demonstrated by the test output. The decision to keep or remove the test files is up to you, as they're supplementary to the main PR task. |
|
@coderabbitai[bot] okay now? I hope no big issue now |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@Aditya08Vashisht Let me check the current state of your PR to make sure everything is in order now. Based on my review, it appears that you've made good progress with the AsyncAPI v3 updates. The tutorial documents have been properly updated to use AsyncAPI v3 format, and the parser implementation has been updated to handle the v3 specification. I notice that you've decided to remove the test files (example-asyncapi.yml and test-parser.js) or update them to v3, which is a good decision to keep the PR focused on the core task. The previously discussed package.json and turbo.json files that were accidentally included from another PR have been properly removed. Your PR looks ready now! The changes align well with the goal of issue #1503 to update the tutorial for AsyncAPI v3. Is there anything specific you'd like me to check or explain about the implementation? 🏁 Script executed: Length of output: 12116 @Aditya08Vashisht Yes, everything looks good now! 👍 I've carefully checked all the key aspects of your PR:
Your PR now looks ready for review and appears to fully address the requirements of issue #1503. The changes are clean and focused on the AsyncAPI v3 tutorial update. Great work! 🎉 If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 3643 @Aditya08Vashisht Everything looks good now! I've checked all the key files and can confirm:
All the major issues that we identified earlier have been addressed. The code is now properly updated for AsyncAPI v3 support, which aligns perfectly with the goal of issue #1503. Great work on implementing these changes! 👍 |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@Aditya08Vashisht Yes, everything looks good now! 👍 I've carefully checked all the key aspects of your PR:
Your PR now looks ready for review and appears to fully address the requirements of issue #1503. The changes are clean and focused on the AsyncAPI v3 tutorial update. Great work! 🎉 🏁 Script executed: Length of output: 12116 @Aditya08Vashisht Yes, everything looks good now! 👍 I've carefully analyzed the results and all key aspects of your PR have been properly addressed:
Your PR is now ready for review and fully addresses the requirements of issue #1503. The changes are clean and focused on the AsyncAPI v3 tutorial update. Great work! 🎉 |
Aditya08Vashisht
changed the title
|
so i have done a lot of updations and self-review and with the help and guidance of this nice bot @coderabbitai[bot] |
|
Tip For best results, initiate chat on the files or code changes. @Aditya08Vashisht You're welcome! I'm glad I could be of assistance throughout this process. Your PR looks good now with all the key AsyncAPI v3 updates in place - both the documentation changes and the parser API updates. The changes are clean, focused on the core requirements of issue #1503, and you've addressed all the issues we discussed. I believe it's ready for @derberg's review. If you need any further assistance or have questions during the review process, feel free to ask! 👍 |
Okay @derberg I'll do the changes for only the template and not the others for testing |
if you remember i have worked on the basis of this Done(edited) |
|
|
|
closing in favour of #1551 |
yes please! |
This PR rewrites the tutorial based on AsyncAPI v3 accordingly for AsyncAPI docs and code parser API usage updations.
Fixes: #1503
also i have verified it via opening the index file through the live server.
Summary by CodeRabbit
New Features
Documentation
Chores