Skip to content

feat: quarkus websocket structure #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ssala034
Copy link
Contributor

@ssala034 ssala034 commented Jun 4, 2025

No description provided.

Copy link

changeset-bot bot commented Jun 4, 2025

⚠️ No Changeset found

Latest commit: 9ab40f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

coderabbitai bot commented Jun 4, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarqubecloud bot commented Jun 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ssala034 ssala034 changed the title Quarkus websocket feat: quarkus websocket structure Jun 4, 2025
@derberg
Copy link
Member

derberg commented Jun 4, 2025

you forgot about adding a config file for the template. You need to look into docs and basic requirements for template, and refresh the tutorial about template creation.

with last release, config can be placed outside package.json - look on other websocket templates

@ssala034
Copy link
Contributor Author

ssala034 commented Jun 4, 2025

you forgot about adding a config file for the template. You need to look into docs and basic requirements for template, and refresh the tutorial about template creation.

with last release, config can be placed outside package.json - look on other websocket templates

Ah I see, forgot about that. Thanks for spotting that. 💯

@AayushSaini101
Copy link
Contributor

@ssala034 Please add proper description as well, and also you can start small by small changes so that it would be easy for the review process thanks

@ssala034
Copy link
Contributor Author

ssala034 commented Jun 5, 2025

@ssala034 Please add proper description as well, and also you can start small by small changes so that it would be easy for the review process thanks

@AayushSaini101, currently I am trying to generate models from a spec file. Once I can generate model I am going to try to inject certain annotations so I can send websocket messages. I am using websocket-next dependency
( https://quarkus.io/guides/websockets-next-tutorial)
Is that a good starting point or should I try even smaller goal.

I plan on documenting my changes + descriptions on the pr in the future. I just had trouble running my code and the best way to figure it out was to share in a draft PR. Thanks for the reminder.

@AayushSaini101
Copy link
Contributor

@ssala034 Please add proper description as well, and also you can start small by small changes so that it would be easy for the review process thanks

@AayushSaini101, currently I am trying to generate models from a spec file. Once I can generate model I am going to try to inject certain annotations so I can send websocket messages. I am using websocket-next dependency ( https://quarkus.io/guides/websockets-next-tutorial) Is that a good starting point or should I try even smaller goal.

I plan on documenting my changes + descriptions on the pr in the future. I just had trouble running my code and the best way to figure it out was to share in a draft PR. Thanks for the reminder.

  • First explain the structure format and add in the readme
  • Then step by step perform the changes genreate models from a spec file would be good
  • Try to write test case as well for every small changes you made thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants