-
-
Notifications
You must be signed in to change notification settings - Fork 300
feat: quarkus websocket structure #1605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
you forgot about adding a config file for the template. You need to look into docs and basic requirements for template, and refresh the tutorial about template creation. with last release, config can be placed outside package.json - look on other websocket templates |
Ah I see, forgot about that. Thanks for spotting that. 💯 |
@ssala034 Please add proper description as well, and also you can start small by small changes so that it would be easy for the review process thanks |
@AayushSaini101, currently I am trying to generate models from a spec file. Once I can generate model I am going to try to inject certain annotations so I can send websocket messages. I am using websocket-next dependency I plan on documenting my changes + descriptions on the pr in the future. I just had trouble running my code and the best way to figure it out was to share in a draft PR. Thanks for the reminder. |
|
No description provided.