-
-
Notifications
You must be signed in to change notification settings - Fork 302
PR Review Checklist
-
PR Title: Use a concise title that follows our Conventional Commits guidelines and clearly summarizes the change using imperative mood (it means
spoken or written as if giving a command or instruction
, like "add new helper for listing operations")Note - In Generator, prepend
feat:
orfix:
in PR title only when PATCH/MINOR release must be triggered. -
PR Description: Clearly explain the issue being solved, summarize the changes made, and mention the related issue.
Note - In Generator, we use Maintainers Work board to track progress. Ensure the PR Description includes
Resolves #<issue-number>
orFixes #<issue-number>
this will automatically close the linked issue when the PR is merged and helps automate the maintainers workflow. -
Documentation: Update the relevant Generator documentation to accurately reflect the changes introduced in the PR, ensuring users and contributors have up-to-date guidance.
-
Comments and JSDoc: Write clear and consistent JSDoc comments for functions, including parameter types, return values, and error conditions, so others can easily understand and use the code.
-
DRY Code: Ensure the code follows the Don't Repeat Yourself principle. Look out for duplicate logic that can be reused.
-
Test Coverage: Ensure the new code is well-tested with meaningful test cases that pass consistently and cover all relevant edge cases.
-
Commit History: Contributors should avoid force-pushing as much as possible. It makes it harder to track incremental changes and review the latest updates.
-
Template Design Principles Alignment: While reviewing template-related changes in the
packages/
directory, ensure they align with the Assumptions and Principles. If any principle feels outdated or no longer applicable, start a discussion these principles are meant to evolve with the project.