Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: FreeBSD passing even when build/pack fails #1435

Open
petermm opened this issue Dec 28, 2024 · 0 comments
Open

CI: FreeBSD passing even when build/pack fails #1435

petermm opened this issue Dec 28, 2024 · 0 comments

Comments

@petermm
Copy link
Contributor

petermm commented Dec 28, 2024

This run is green, even though it clearly failed.

https://github.com/atomvm/AtomVM/actions/runs/12519630181/job/34923994581?pr=1429#step:3:3074

  [  6%] Packing archive code_load_pack.avm
  PackBeam: Cannot open file 'code_load_pack.avm'.
  *** Error code 1
  
  Stop.
  make[2]: stopped in /home/runner/work/AtomVM/AtomVM/build
  *** Error code 1
  
  Stop.
  make[1]: stopped in /home/runner/work/AtomVM/AtomVM/build
  *** Error code 1
  
  Stop.
  make: stopped in /home/runner/work/AtomVM/AtomVM/build
  sh: atomvm: not found
  sh: atomvm: not found
  sh: atomvm: not found
  %%
  %% Done!
  %%
petermm added a commit to petermm/AtomVM that referenced this issue Dec 28, 2024
@petermm
Fix FreeBSD CI not exiting on error
5e05cb1 
Fixes atomvm#1435

Signed-off-by: Peter M <[email protected]>
@petermm petermm mentioned this issue Dec 28, 2024
Closed
petermm added a commit to petermm/AtomVM that referenced this issue Jan 19, 2025
@petermm
Fix FreeBSD CI not exiting on error
3280441 
Fixes atomvm#1435

Signed-off-by: Peter M <[email protected]>
@UncleGrumpy UncleGrumpy mentioned this issue Jan 19, 2025
Merged
bettio added a commit that referenced this issue Jan 21, 2025
@bettio
Merge pull request #1478 from UncleGrumpy/test-on-freebsd
be8c7e9 
Make build-and-test-on-freebsd fail if steps do not complete successfully

Updates the Ubuntu host to 24.04, and changes to as matrix build with the
current stable (14.2) and latest legacy release update (13.4) versions of
FreeBSD.

This workflow is a different from most in that the entire build and test is
done in a single script in a FreeBSB container on an Ubuntu host. Because it is
one large shell script with no separate "jobs" exits needed to be added to
ensure the test fails if any important steps fail to complete successfully.

Adds missing rebar3 installation required to complete the tests build.

Closes #1435

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petermm